feat[scalar_fn]: binary ops

joseph-isaacs · joseph-isaacs · commit c223eaaf8193 · 2025-12-02T10:42:32.000-05:00
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/vortex-array/src/scalar_fns/binary/mod.rs b/vortex-array/src/scalar_fns/binary/mod.rs
@@ -53,9 +53,7 @@ impl VTable for BinaryFn {
 
     fn null_handling(&self, options: &Operator) -> NullHandling {
         match options {
-            // Kleene logic for AND/OR - they have special null semantics
             Operator::And | Operator::Or => NullHandling::AbsorbsNull,
-            // All other operators propagate nulls
             _ => NullHandling::Propagate,
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,7 @@ impl VTable for BinaryFn {`
`53`	`53`
`54`	`54`	`fn null_handling(&self, options: &Operator) -> NullHandling {`
`55`	`55`	`match options {`
`56`		`- // Kleene logic for AND/OR - they have special null semantics`
`57`	`56`	`Operator::And \| Operator::Or => NullHandling::AbsorbsNull,`
`58`		`- // All other operators propagate nulls`
`59`	`57`	`_ => NullHandling::Propagate,`
`60`	`58`	`}`
`61`	`59`	`}`