Filter pushdown

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-array/src/arrays/scalar_fn/vtable/mod.rs

@@ -161,7 +161,7 @@ pub trait ScalarFnArrayExt: expr::VTable {
         options: Self::Options,
         children: impl Into<Vec<ArrayRef>>,
     ) -> VortexResult<ArrayRef> {
-        let bound = ScalarFn::new_static(self, options);
+        let scalar_fn = ScalarFn::new_static(self, options);
 
         let children = children.into();
         vortex_ensure!(
@@ -170,16 +170,16 @@ pub trait ScalarFnArrayExt: expr::VTable {
         );
 
         let child_dtypes = children.iter().map(|c| c.dtype().clone()).collect_vec();
-        let dtype = bound.return_dtype(&child_dtypes)?;
+        let dtype = scalar_fn.return_dtype(&child_dtypes)?;
 
         let array_vtable: ArrayVTable = ScalarFnVTable {
-            vtable: bound.vtable().clone(),
+            vtable: scalar_fn.vtable().clone(),
         }
         .into_vtable();
 
         Ok(ScalarFnArray {
             vtable: array_vtable,
-            scalar_fn: bound,
+            scalar_fn,
             dtype,
             len,
             children,

vortex-array/src/expr/display.rs

@@ -19,8 +19,8 @@ impl Display for DisplayTreeExpr<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         pub use termtree::Tree;
         fn make_tree(expr: &Expression) -> Result<Tree<String>, std::fmt::Error> {
-            let bound: &ScalarFn = expr.deref();
-            let node_name = format!("{}", bound);
+            let scalar_fn: &ScalarFn = expr.deref();
+            let node_name = format!("{}", scalar_fn);
 
             // Get child names for display purposes
             let child_names = (0..expr.children().len()).map(|i| expr.signature().child_name(i));

vortex-array/src/expr/session/mod.rs vortex-array/src/expr/session.rsvortex-array/src/expr/session/mod.rs renamed to vortex-array/src/expr/session.rs

@@ -1,8 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
-// mod rewrite;
-
 use vortex_session::Ref;
 use vortex_session::SessionExt;
 use vortex_session::registry::Registry;