Try and unblock release by publishing GPU code

Signed-off-by: Adam Gutglick <[email protected]>

Author: AdamGS

.github/workflows/ci.yml

@@ -415,6 +415,7 @@ jobs:
       # Keep frame pointers for better stack traces
       CARGO_PROFILE_DEV_DEBUG: "true"
       CARGO_PROFILE_TEST_DEBUG: "true"
+      RUSTFLAGS: "--cfg gpu_unstable"
     steps:
       - uses: runs-on/action@v2
         with:

.github/workflows/publish.yml

@@ -34,14 +34,7 @@ jobs:
 
       - name: Release
         run: |
-          cargo +nightly publish -Zpublish-timeout --no-verify --allow-dirty --workspace \
-          --exclude bench-vortex \
-          --exclude vortex-python \
-          --exclude vortex-duckdb \
-          --exclude vortex-ffi \
-          --exclude vortex-fuzz \
-          --exclude vortex-jni \
-          --exclude xtask
+          cargo +nightly publish -Zpublish-timeout --no-verify --allow-dirty --workspace
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}

Cargo.toml

@@ -281,6 +281,7 @@ unexpected_cfgs = { level = "deny", check-cfg = [
     "cfg(codspeed)",
     "cfg(disable_loom)",
     "cfg(vortex_nightly)",
+    "cfg(gpu_unstable)",
 ] }
 warnings = "warn"
 

vortex-buffer/Cargo.toml

@@ -18,7 +18,6 @@ all-features = true
 
 [features]
 arrow = []
-cuda = ["dep:cudarc"]
 memmap2 = ["dep:memmap2"]
 serde = ["dep:serde"]
 warn-copy = ["dep:log"]
@@ -27,7 +26,6 @@ warn-copy = ["dep:log"]
 arrow-buffer = { workspace = true }
 bitvec = { workspace = true }
 bytes = { workspace = true }
-cudarc = { workspace = true, optional = true }
 itertools = { workspace = true }
 log = { workspace = true, optional = true }
 memmap2 = { workspace = true, optional = true }
@@ -36,6 +34,9 @@ serde = { workspace = true, optional = true }
 simdutf8 = { workspace = true }
 vortex-error = { workspace = true }
 
+[target.'cfg(gpu_unstable)'.dependencies]
+cudarc = { workspace = true }
+
 [lints]
 workspace = true
 

vortex-buffer/src/lib.rs

@@ -64,7 +64,7 @@ mod buffer;
 mod buffer_mut;
 mod bytes;
 mod r#const;
-#[cfg(feature = "cuda")]
+#[cfg(gpu_unstable)]
 mod cuda;
 mod debug;
 mod macros;

vortex-file/Cargo.toml

@@ -19,7 +19,6 @@ all-features = true
 [dependencies]
 async-trait = { workspace = true }
 bytes = { workspace = true }
-cudarc = { workspace = true, optional = true }
 flatbuffers = { workspace = true }
 futures = { workspace = true, features = ["std", "async-await"] }
 # Needed to pickup the "wasm_js" feature for wasm targets from the workspace configuration
@@ -43,7 +42,6 @@ vortex-error = { workspace = true }
 vortex-fastlanes = { workspace = true }
 vortex-flatbuffers = { workspace = true, features = ["file"] }
 vortex-fsst = { workspace = true }
-vortex-gpu = { workspace = true, optional = true }
 vortex-io = { workspace = true }
 vortex-layout = { workspace = true }
 vortex-metrics = { workspace = true }
@@ -77,10 +75,7 @@ tokio = [
     "vortex-scan/tokio",
 ]
 zstd = ["dep:vortex-zstd", "vortex-layout/zstd"]
-gpu = [
-    "dep:cudarc",
-    "dep:vortex-gpu",
-    "vortex-gpu/cuda",
-    "vortex-layout/gpu",
-    "vortex-scan/gpu",
-]
+
+[target.'cfg(gpu_unstable)'.dependencies]
+cudarc = { workspace = true }
+vortex-gpu = { workspace = true, features = ["cuda"] }

vortex-file/src/file.rs

@@ -96,7 +96,7 @@ impl VortexFile {
         )
     }
 
-    #[cfg(feature = "gpu")]
+    #[cfg(gpu_unstable)]
     pub fn gpu_scan(
         &self,
         ctx: Arc<cudarc::driver::CudaContext>,

vortex-gpu-kernels/Cargo.toml

@@ -12,7 +12,6 @@ readme = { workspace = true }
 repository = { workspace = true }
 rust-version = { workspace = true }
 version = { workspace = true }
-publish = false
 
 [lib]
 name = "vortex_gpu_kernels"

vortex-gpu/Cargo.toml

@@ -12,15 +12,14 @@ readme = { workspace = true }
 repository = { workspace = true }
 rust-version = { workspace = true }
 version = { workspace = true }
-publish = false
 
 [dependencies]
 cudarc = { workspace = true }
 itertools = { workspace = true }
 parking_lot = { workspace = true }
 vortex-alp = { workspace = true }
 vortex-array = { workspace = true }
-vortex-buffer = { workspace = true, features = ["cuda"] }
+vortex-buffer = { workspace = true }
 vortex-dtype = { workspace = true }
 vortex-error = { workspace = true }
 vortex-fastlanes = { workspace = true }

vortex-gpu/src/lib.rs

@@ -1,6 +1,14 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+//! This crate contains support for GPU and CUDA accelerated compute for Vortex.
+//!
+//! This crate is currently considered unstable, and much of its code is behind a the `gpu_unstable` config.
+//! If you wish to use it, you should build your code with:
+//! ```shell
+//! RUSTFLAGS="--cfg gpu_unstable" cargo build -p ...
+//! ```
+
 pub mod bit_unpack;
 pub mod for_;
 mod for_bp;