Skip to content

Commit c5a8e20

Browse files
fix: comments (#1923)
follow up to #1919
1 parent 99eb574 commit c5a8e20

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

vortex-layout/src/layouts/struct_/eval_expr.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ impl ExprEvaluator for StructReader {
2020
let field_readers: Vec<_> = partitioned
2121
.partitions
2222
.iter()
23-
// TODO(joe): remove field from self.child
2423
.map(|partition| self.child(&partition.name.clone()))
2524
.try_collect()?;
2625

vortex-layout/src/layouts/struct_/reader.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ impl StructReader {
6969
.get(name)
7070
.ok_or_else(|| vortex_err!("Field {} not found in struct layout", name))?;
7171

72-
// TODO: think about a hashmap for large |fields|.
72+
// TODO: think about a Hashmap<FieldName, OnceLock<Arc<dyn LayoutReader>>> for large |fields|.
7373
self.field_readers[idx].get_or_try_init(|| {
7474
let child_layout = self
7575
.layout

0 commit comments

Comments
 (0)