chore[fastlanes]: remove FoR unsigned transmute (#4252)

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

docs/quickstart/python.rst

@@ -37,7 +37,7 @@ Use :func:`~vortex.compress` to compress the Vortex array and check the relative
 
    >>> cvtx = vx.compress(vtx)
    >>> cvtx.nbytes
-   14297
+   14298
    >>> cvtx.nbytes / vtx.nbytes
    0.10...
 

encodings/fastlanes/src/for/compress.rs

@@ -20,10 +20,7 @@ impl FoRArray {
             .ok_or_else(|| vortex_err!("Min stat not found"))?;
 
         let encoded = match_each_integer_ptype!(array.ptype(), |T| {
-            let unsigned_ptype = array.ptype().to_unsigned();
-            compress_primitive::<T>(array, T::try_from(&min)?)?
-                .reinterpret_cast(unsigned_ptype)
-                .into_array()
+            compress_primitive::<T>(array, T::try_from(&min)?)?.into_array()
         });
         FoRArray::try_new(encoded, min)
     }
@@ -49,7 +46,7 @@ pub fn decompress(array: &FoRArray) -> VortexResult<PrimitiveArray> {
     let ptype = array.ptype();
 
     // TODO(ngates): do we need this to be into_encoded() somehow?
-    let encoded = array.encoded().to_primitive()?.reinterpret_cast(ptype);
+    let encoded = array.encoded().to_primitive()?;
     let validity = encoded.validity().clone();
 
     Ok(match_each_integer_ptype!(ptype, |T| {
@@ -82,6 +79,7 @@ mod test {
     use vortex_array::ToCanonical;
     use vortex_array::validity::Validity;
     use vortex_buffer::buffer;
+    use vortex_dtype::PType;
     use vortex_scalar::Scalar;
 
     use super::*;
@@ -109,10 +107,10 @@ mod test {
         let compressed = FoRArray::encode(array).unwrap();
         assert_eq!(compressed.dtype(), &dtype);
         assert!(compressed.dtype().is_signed_int());
-        assert!(compressed.encoded().dtype().is_unsigned_int());
+        assert!(compressed.encoded().dtype().is_signed_int());
 
         let constant = compressed.encoded().as_constant().unwrap();
-        assert_eq!(constant, Scalar::from(0u32));
+        assert_eq!(constant, Scalar::from(0i32));
     }
 
     #[test]
@@ -137,7 +135,11 @@ mod test {
                 .unwrap()
         );
 
-        let encoded = compressed.encoded().to_primitive().unwrap();
+        let encoded = compressed
+            .encoded()
+            .to_primitive()
+            .unwrap()
+            .reinterpret_cast(PType::U8);
         let encoded_bytes: &[u8] = encoded.as_slice::<u8>();
         let unsigned: Vec<u8> = (0..=u8::MAX).collect_vec();
         assert_eq!(encoded_bytes, unsigned.as_slice());

encodings/fastlanes/src/for/compute/compare.rs

@@ -68,7 +68,7 @@ where
 
     // Wrap up the RHS into a scalar and cast to the encoded DType (this will be the equivalent
     // unsigned integer type).
-    let rhs = Scalar::primitive(rhs, nullability).reinterpret_cast(T::PTYPE.to_unsigned());
+    let rhs = Scalar::primitive(rhs, nullability);
 
     compare(
         lhs.encoded(),
@@ -94,7 +94,7 @@ mod tests {
         let reference = Scalar::from(10);
         // 10, 30, 12
         let lhs = FoRArray::try_new(
-            PrimitiveArray::new(buffer!(0u32, 20, 2), Validity::AllValid).into_array(),
+            PrimitiveArray::new(buffer!(0i32, 20, 2), Validity::AllValid).into_array(),
             reference,
         )
         .unwrap();
@@ -121,7 +121,7 @@ mod tests {
         let reference = Scalar::from(0);
         // 10, 30, 12
         let lhs = FoRArray::try_new(
-            PrimitiveArray::new(buffer!(0u32, 20, 2), Validity::NonNullable).into_array(),
+            PrimitiveArray::new(buffer!(0i32, 20, 2), Validity::NonNullable).into_array(),
             reference,
         )
         .unwrap();
@@ -147,7 +147,7 @@ mod tests {
         let reference = Scalar::from(10);
         // 10, 30, 12
         let lhs = FoRArray::try_new(
-            PrimitiveArray::new(buffer!(0u32, 10, 1), Validity::AllValid).into_array(),
+            PrimitiveArray::new(buffer!(0i32, 10, 1), Validity::AllValid).into_array(),
             reference,
         )
         .unwrap();
@@ -165,9 +165,13 @@ mod tests {
     #[test]
     fn compare_large_constant() {
         let reference = Scalar::from(-9219218377546224477i64);
+        #[allow(clippy::cast_possible_truncation)]
         let lhs = FoRArray::try_new(
-            PrimitiveArray::new(buffer![0u64, 9654309310445864926], Validity::AllValid)
-                .into_array(),
+            PrimitiveArray::new(
+                buffer![0i64, 9654309310445864926u64 as i64],
+                Validity::AllValid,
+            )
+            .into_array(),
             reference,
         )
         .unwrap();
@@ -176,7 +180,7 @@ mod tests {
             compare_constant(
                 &lhs,
                 435090932899640449i64,
-                Nullability::NonNullable,
+                Nullability::Nullable,
                 Operator::Eq,
             ),
             [false, true],
@@ -185,7 +189,7 @@ mod tests {
             compare_constant(
                 &lhs,
                 435090932899640449i64,
-                Nullability::NonNullable,
+                Nullability::Nullable,
                 Operator::NotEq,
             ),
             [true, false],

encodings/fastlanes/src/for/ops.rs

@@ -19,10 +19,7 @@ impl OperationsVTable<FoRVTable> for FoRVTable {
     }
 
     fn scalar_at(array: &FoRArray, index: usize) -> VortexResult<Scalar> {
-        let encoded_pvalue = array
-            .encoded()
-            .scalar_at(index)?
-            .reinterpret_cast(array.ptype());
+        let encoded_pvalue = array.encoded().scalar_at(index)?;
         let encoded_pvalue = encoded_pvalue.as_primitive();
         let reference = array.reference_scalar();
         let reference = reference.as_primitive();

encodings/fastlanes/src/for/serde.rs

@@ -9,7 +9,7 @@ use vortex_array::{
     ArrayBufferVisitor, ArrayChildVisitor, Canonical, DeserializeMetadata, SerializeMetadata,
 };
 use vortex_buffer::ByteBuffer;
-use vortex_dtype::{DType, PType};
+use vortex_dtype::DType;
 use vortex_error::{VortexResult, vortex_bail};
 use vortex_scalar::{Scalar, ScalarValue};
 
@@ -40,10 +40,7 @@ impl SerdeVTable<FoRVTable> for FoRVTable {
             )
         }
 
-        let ptype = PType::try_from(dtype)?;
-        let encoded_dtype = DType::Primitive(ptype.to_unsigned(), dtype.nullability());
-        let encoded = children.get(0, &encoded_dtype, len)?;
-
+        let encoded = children.get(0, dtype, len)?;
         let reference = Scalar::new(dtype.clone(), metadata.clone());
 
         FoRArray::try_new(encoded, reference)