feat[vortex-array]: add an expr array

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/arrays/expr/vtable/canonical.rs

@@ -34,19 +34,15 @@ mod tests {
     fn test_expr_array_canonicalize() {
         let child = PrimitiveArray::new(buffer![1i32, 2, 3], Validity::NonNullable).into_array();
 
-        // Create an expression: lit(10) + lit(5) = 15
         // This expression doesn't use the child, but demonstrates the ExprArray mechanics
         let expr = checked_add(lit(10), lit(5));
 
-        // Create ExprArray with the expression
         let dtype = DType::Primitive(PType::I32, NonNullable);
         let expr_array = ExprArray::try_new(child, expr, dtype).unwrap();
-        let array = expr_array.into_array();
 
-        // Test canonicalize - should evaluate the expression
-        let canonical = array.to_canonical().into_array();
+        let actual = expr_array.to_canonical().into_array();
 
         let expect = (0..3).map(|_| 15i32).collect::<PrimitiveArray>();
-        assert_eq!(expect, canonical);
+        assert_eq!(expect, actual);
     }
 }

vortex-array/src/arrays/expr/vtable/operator.rs

@@ -39,7 +39,6 @@ impl OperatorVTable<ExprVTable> for ExprVTable {
 
 #[cfg(test)]
 mod tests {
-    #![allow(clippy::redundant_clone)]
 
     use vortex_dtype::Nullability;
     use vortex_error::VortexExpect;

vortex-layout/src/layouts/struct_/reader.rs

@@ -187,6 +187,7 @@ impl StructReader {
 
 /// When partitioning an expression, in the case it only has a single partition we can avoid
 /// some cost and just delegate to the child reader directly.
+// TODO(joe): this is a duplicate of the Partitioned enum in arrays/expr/vtable/operator.rs
 #[derive(Clone)]
 enum Partitioned {
     /// An expression which only operates over a single field