Skip to content

Commit d319b7e

Browse files
committed
ci(bench): Add 10-minute time limit to random_access benchmarks
Add --time-limit 600 (10 minutes) flag to random_access benchmark runs in both bench.yml and bench-pr.yml workflows. This ensures all targets (Vortex, Lance, Parquet) run for the same duration, providing fair comparison despite different performance characteristics. The time limit is conditionally applied only to random_access benchmarks, leaving other benchmarks (like compress) unchanged.
1 parent 03d4520 commit d319b7e

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/workflows/bench-pr.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,11 @@ jobs:
8484
env:
8585
RUST_BACKTRACE: full
8686
run: |
87-
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json
87+
if [ "${{ matrix.benchmark.id }}" = "random_access" ]; then
88+
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json --time-limit 600
89+
else
90+
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json
91+
fi
8892
8993
- name: Setup AWS CLI
9094
if: github.event.pull_request.head.repo.fork == false

.github/workflows/bench.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,11 @@ jobs:
8585
env:
8686
RUST_BACKTRACE: full
8787
run: |
88-
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json --formats parquet,lance,vortex
88+
if [ "${{ matrix.benchmark.id }}" = "random_access" ]; then
89+
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json --formats parquet,lance,vortex --time-limit 600
90+
else
91+
target/release_debug/${{ matrix.benchmark.id }} -d gh-json -o ${{ matrix.benchmark.id }}.json --formats parquet,lance,vortex
92+
fi
8993
9094
- name: Setup AWS CLI
9195
uses: aws-actions/configure-aws-credentials@v5

0 commit comments

Comments
 (0)