Reopen DuckDB between iterations

Signed-off-by: Adam Gutglick <[email protected]>

Author: AdamGS

benchmarks/ddb-bench/src/main.rs

@@ -129,7 +129,11 @@ async fn main() -> anyhow::Result<()> {
             ctx.register_tables(&*benchmark, format)?;
             Ok(ctx)
         },
-        |ctx, _query_idx, query| ctx.execute_query(query),
+        |ctx, _query_idx, query| {
+            // Make sure to reopen the duckdb connection between iterations
+            ctx.reopen()?;
+            ctx.execute_query(query)
+        },
     )?;
 
     let benchmark_id = format!("duckdb-{}", benchmark.dataset_name());

vortex-bench/src/runner.rs

@@ -316,16 +316,16 @@ impl SqlBenchmarkRunner {
     ) -> anyhow::Result<()>
     where
         S: FnMut(Format) -> anyhow::Result<Ctx>,
-        E: FnMut(&Ctx, usize, &str) -> anyhow::Result<usize>,
+        E: FnMut(&mut Ctx, usize, &str) -> anyhow::Result<usize>,
     {
         for format in self.formats.clone() {
-            let ctx = setup(format)?;
+            let mut ctx = setup(format)?;
 
             for (query_idx, query) in queries.iter() {
                 let query_idx = *query_idx;
                 self.run_query(query_idx, format, iterations, || {
                     let row_count =
-                        execute(&ctx, query_idx, query.as_str()).unwrap_or_else(|err| {
+                        execute(&mut ctx, query_idx, query.as_str()).unwrap_or_else(|err| {
                             vortex_panic!("query {query_idx} failed: {err}");
                         });
                     (row_count, ())