wip

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

encodings/alp/src/alp/compress.rs

@@ -161,7 +161,7 @@ pub fn decompress(array: ALPArray) -> PrimitiveArray {
 /// # Returns
 ///
 /// A `PrimitiveArray` containing the decompressed values with all patches applied.
-#[allow(clippy::cognitive_complexity)]
+#[expect(clippy::cognitive_complexity, reason = "complexity is from nested match_each_* macros")]
 pub fn decompress_chunked(
     array: ALPArray,
     patches: &Patches,

encodings/alp/src/alp/mod.rs

@@ -154,7 +154,7 @@ pub trait ALPFloat: private::Sealed + Float + Display + NativePType {
         encoded_bytes + patch_bytes
     }
 
-    #[allow(clippy::type_complexity)]
+    #[expect(clippy::type_complexity, reason = "tuple return type is appropriate for multiple encoding outputs")]
     fn encode(
         values: &[Self],
         exponents: Option<Exponents>,

encodings/fastlanes/src/rle/array/mod.rs

@@ -127,7 +127,6 @@ impl RLEArray {
     /// - The `indices` array contains valid indices into chunks of the `values` array
     /// - The `values_idx_offsets` array contains valid chunk start offsets
     /// - The `validity` array has the same length as `length`
-    #[allow(clippy::too_many_arguments)]
     pub unsafe fn new_unchecked(
         values: ArrayRef,
         indices: ArrayRef,
@@ -182,7 +181,7 @@ impl RLEArray {
     /// Offsets in `values_idx_offsets` are absolute and need to be shifted
     /// by the offset of the first chunk, respective the current slice, in
     /// order to make them relative.
-    #[allow(clippy::expect_used)]
+    #[expect(clippy::expect_used, reason = "expect is safe here as scalar_at returns a valid primitive")]
     pub(crate) fn values_idx_offset(&self, chunk_idx: usize) -> usize {
         self.values_idx_offsets
             .scalar_at(chunk_idx)

encodings/fastlanes/src/rle/array/rle_decompress.rs

@@ -19,7 +19,7 @@ use crate::FL_CHUNK_SIZE;
 use crate::RLEArray;
 
 /// Decompresses an RLE array back into a primitive array.
-#[allow(clippy::cognitive_complexity)]
+#[expect(clippy::cognitive_complexity, reason = "complexity is from nested match_each_* macros")]
 pub fn rle_decompress(array: &RLEArray) -> PrimitiveArray {
     match_each_native_ptype!(array.values().dtype().as_ptype(), |V| {
         match_each_unsigned_integer_ptype!(array.values_idx_offsets().dtype().as_ptype(), |O| {
@@ -37,7 +37,6 @@ pub fn rle_decompress(array: &RLEArray) -> PrimitiveArray {
 }
 
 /// Decompresses an `RLEArray` into to a primitive array of unsigned integers.
-#[allow(clippy::cognitive_complexity)]
 fn rle_decode_typed<V, I, O>(array: &RLEArray) -> PrimitiveArray
 where
     V: NativePType + RLE + Clone + Copy,

encodings/fsst/src/canonical.rs

@@ -50,7 +50,7 @@ impl CanonicalVTable<FSSTVTable> for FSSTVTable {
     }
 }
 
-#[allow(clippy::cast_possible_truncation)]
+#[expect(clippy::cast_possible_truncation, reason = "truncation is intentional for buffer index")]
 fn fsst_decode_views(fsst_array: &FSSTArray, buf_index: u32) -> (ByteBuffer, Buffer<BinaryView>) {
     // FSSTArray has two child arrays:
     //  1. A VarBinArray, which holds the string heap of the compressed codes.

encodings/sparse/src/canonical.rs

@@ -115,7 +115,7 @@ impl CanonicalVTable<SparseVTable> for SparseVTable {
     }
 }
 
-#[allow(clippy::cognitive_complexity)]
+#[expect(clippy::cognitive_complexity, reason = "complexity is from nested match_smallest_offset_type macro")]
 fn canonicalize_sparse_lists(
     array: &SparseArray,
     values_dtype: Arc<DType>,

vortex-array/src/arrays/primitive/array/conversion.rs

@@ -110,7 +110,6 @@ impl PrimitiveArray {
     }
 
     /// Try to extract a mutable buffer from the PrimitiveArray with zero copy.
-    #[allow(clippy::panic_in_result_fn)]
     pub fn try_into_buffer_mut<T: NativePType>(self) -> Result<BufferMut<T>, PrimitiveArray> {
         if T::PTYPE != self.ptype() {
             vortex_panic!(

vortex-array/src/arrays/primitive/array/patch.rs

@@ -14,7 +14,6 @@ use crate::validity::Validity;
 use crate::vtable::ValidityHelper;
 
 impl PrimitiveArray {
-    #[allow(clippy::cognitive_complexity)]
     pub fn patch(self, patches: &Patches) -> Self {
         let patch_indices = patches.indices().to_primitive();
         let patch_values = patches.values().to_primitive();
@@ -72,7 +71,7 @@ impl PrimitiveArray {
 /// * `base_offset` - Base offset from the first chunk
 /// * `offset_within_chunk` - Offset within chunk for sliced patches
 #[inline]
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments, reason = "all arguments are needed for the patching operation")]
 pub fn patch_chunk<T, I, C>(
     decoded_values: &mut [T],
     patches_indices: &[I],

vortex-array/src/arrays/struct_/array.rs

@@ -381,7 +381,6 @@ impl StructArray {
     /// which specifies the new ordering of columns in the struct. The projection can be used to
     /// perform column re-ordering, deletion, or duplication at a logical level, without any data
     /// copying.
-    #[allow(clippy::same_name_method)]
     pub fn project(&self, projection: &[FieldName]) -> VortexResult<Self> {
         let mut children = Vec::with_capacity(projection.len());
         let mut names = Vec::with_capacity(projection.len());

vortex-array/src/arrays/varbin/array.rs

@@ -243,7 +243,7 @@ impl VarBinArray {
         builder.finish(dtype)
     }
 
-    #[allow(clippy::same_name_method)]
+    #[expect(clippy::same_name_method, reason = "intentionally named from_iter like Iterator::from_iter")]
     pub fn from_iter<T: AsRef<[u8]>, I: IntoIterator<Item = Option<T>>>(
         iter: I,
         dtype: DType,