fix

Author: robert3005

encodings/alp/src/alp/compute/mod.rs

@@ -2,9 +2,7 @@ mod between;
 mod compare;
 mod nan_count;
 
-use std::fmt::Debug;
-
-use vortex_array::compute::{FilterKernel, NanCountFn, ScalarAtFn, SliceFn, TakeFn, scalar_at, slice, take};
+use vortex_array::compute::{NaNCountFn, ScalarAtFn, SliceFn, TakeFn, scalar_at, slice, take};
 use vortex_array::variants::PrimitiveArrayTrait;
 use vortex_array::vtable::ComputeVTable;
 use vortex_array::{Array, ArrayRef};
@@ -14,7 +12,7 @@ use vortex_scalar::Scalar;
 use crate::{ALPArray, ALPEncoding, ALPFloat, match_each_alp_float_ptype};
 
 impl ComputeVTable for ALPEncoding {
-    fn nan_count_fn(&self) -> Option<&dyn NanCountFn<&dyn Array>> {
+    fn nan_count_fn(&self) -> Option<&dyn NaNCountFn<&dyn Array>> {
         Some(self)
     }
     fn scalar_at_fn(&self) -> Option<&dyn ScalarAtFn<&dyn Array>> {

encodings/runend/src/compute/mod.rs

@@ -5,7 +5,6 @@ pub(crate) mod filter;
 mod invert;
 mod is_sorted;
 mod min_max;
-mod nan_count;
 mod scalar_at;
 mod slice;
 pub(crate) mod take;

vortex-array/src/arrays/chunked/compute/take.rs

@@ -6,7 +6,9 @@ use vortex_scalar::Scalar;
 
 use crate::arrays::ChunkedEncoding;
 use crate::arrays::chunked::ChunkedArray;
-use crate::compute::{SearchSortedSide, TakeFn, cast, scalar_at, search_sorted_usize, slice, take};
+use crate::compute::{
+    SearchSortedSide, TakeFn, cast, scalar_at, search_sorted_usize, slice, sub_scalar, take,
+};
 use crate::{Array, ArrayRef, IntoArray, ToCanonical};
 
 impl TakeFn<&ChunkedArray> for ChunkedEncoding {

vortex-array/src/arrays/constant/compute/binary_numeric.rs

@@ -2,6 +2,7 @@ use vortex_error::{VortexResult, vortex_err};
 use vortex_scalar::NumericOperator;
 
 use crate::arrays::{ConstantArray, ConstantEncoding};
+use crate::compute::{NumericKernel, NumericKernelAdapter};
 use crate::{Array, ArrayRef, register_kernel};
 
 impl NumericKernel for ConstantEncoding {

vortex-array/src/arrays/primitive/compute/mod.rs

@@ -1,6 +1,9 @@
 use crate::Array;
 use crate::arrays::PrimitiveEncoding;
-use crate::compute::{FillNullFn, IsConstantFn, IsSortedFn, MaskFn, MinMaxFn, NaNCountFn, ScalarAtFn, SearchSortedFn, SearchSortedUsizeFn, SliceFn, TakeFn, ToArrowFn, UncompressedSizeFn};
+use crate::compute::{
+    FillNullFn, IsConstantFn, IsSortedFn, MaskFn, MinMaxFn, NaNCountFn, ScalarAtFn, SearchSortedFn,
+    SearchSortedUsizeFn, SliceFn, TakeFn, ToArrowFn, UncompressedSizeFn,
+};
 use crate::vtable::ComputeVTable;
 
 mod between;

vortex-array/src/builders/list.rs

@@ -10,7 +10,7 @@ use vortex_scalar::{ListScalar, NumericOperator};
 use crate::arrays::{ConstantArray, ListArray, OffsetPType};
 use crate::builders::lazy_validity_builder::LazyNullBufferBuilder;
 use crate::builders::{ArrayBuilder, ArrayBuilderExt, PrimitiveBuilder, builder_with_capacity};
-use crate::compute::{cast, slice};
+use crate::compute::{cast, numeric, slice};
 use crate::{Array, ArrayRef, ToCanonical};
 
 pub struct ListBuilder<O: NativePType> {

vortex-array/src/compute/mod.rs

@@ -24,6 +24,7 @@ pub use like::{LikeFn, LikeOptions, like};
 pub use mask::{MaskFn, mask};
 pub use min_max::{MinMaxFn, MinMaxResult, min_max};
 pub use nan_count::*;
+pub use numeric::*;
 pub use optimize::*;
 pub use scalar_at::{ScalarAtFn, scalar_at};
 pub use search_sorted::*;

vortex-array/src/stream/take_rows.rs

@@ -7,7 +7,7 @@ use vortex_dtype::match_each_integer_ptype;
 use vortex_error::{VortexResult, vortex_bail};
 use vortex_scalar::Scalar;
 
-use crate::compute::{SearchSortedSide, search_sorted_usize, slice, take};
+use crate::compute::{SearchSortedSide, search_sorted_usize, slice, sub_scalar, take};
 use crate::stats::Stat;
 use crate::stream::ArrayStream;
 use crate::variants::PrimitiveArrayTrait;