Skip to content

Commit d9b7c16

Browse files
committed
drop ls dir
Signed-off-by: Alexander Droste <[email protected]>
1 parent 08351cd commit d9b7c16

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

.github/workflows/sql-benchmarks.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -136,16 +136,11 @@ jobs:
136136
run: GEN=ninja make release
137137
working-directory: ${{ github.workspace }}/duckdb-vortex
138138

139-
140-
- name: List lib dir
141-
shell: bash
142-
run: ls target/lib
143-
144139
- name: Generate data
145140
shell: bash
146141
env:
147142
RUST_BACKTRACE: full
148-
LD_LIBRARY_PATH: target/lib
143+
LD_LIBRARY_PATH: target/duckdb-v1.3.0
149144
run: |
150145
# Generate data, running each query once to make sure they don't panic.
151146
target/release_debug/${{ matrix.binary_name }} --targets datafusion:parquet -i1 -d gh-json --skip-duckdb-build
@@ -177,7 +172,7 @@ jobs:
177172
OTEL_EXPORTER_OTLP_ENDPOINT: '${{ secrets.OTEL_EXPORTER_OTLP_ENDPOINT }}'
178173
OTEL_EXPORTER_OTLP_HEADERS: '${{ secrets.OTEL_EXPORTER_OTLP_HEADERS }}'
179174
OTEL_RESOURCE_ATTRIBUTES: 'bench-name=${{ matrix.id }}'
180-
LD_LIBRARY_PATH: target/lib
175+
LD_LIBRARY_PATH: target/duckdb-v1.3.0
181176
run: |
182177
target/release_debug/${{ matrix.binary_name }} \
183178
-d gh-json \
@@ -196,6 +191,7 @@ jobs:
196191
OTEL_EXPORTER_OTLP_ENDPOINT: '${{ secrets.OTEL_EXPORTER_OTLP_ENDPOINT }}'
197192
OTEL_EXPORTER_OTLP_HEADERS: '${{ secrets.OTEL_EXPORTER_OTLP_HEADERS }}'
198193
OTEL_RESOURCE_ATTRIBUTES: 'bench-name=${{ matrix.id }}'
194+
LD_LIBRARY_PATH: target/duckdb-v1.3.0
199195
run: |
200196
target/release_debug/${{ matrix.binary_name }} \
201197
--use-remote-data-dir ${{ matrix.remote_storage }} \

vortex-duckdb-ext/build.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,6 @@ fn main() {
102102
.write_to_file(crate_dir.join("src/cpp.rs"))
103103
.expect("Couldn't write bindings!");
104104

105-
// To run against a local duckdb library use instead of `lib_path`
106-
// println!(
107-
// "cargo:rustc-link-search=native={}",
108-
// "<>"
109-
// );
110-
// println!(
111-
// "cargo:rustc-link-arg=-Wl,-rpath,{}",
112-
// "<>"
113-
// );
114-
// println!("cargo:rustc-link-lib=static=duckdb");
115-
116105
// Download and extract prebuilt DuckDB libraries.
117106
let zip_path = download_duckdb_archive().unwrap();
118107
let lib_path = extract_duckdb_libraries(zip_path).unwrap();

0 commit comments

Comments
 (0)