Skip to content

Commit da5d463

Browse files
authored
Fix: bring back lance compression benchmark (#5840)
Closes #5837 Turns out it was already implemented, but that one thing wasn't imported. Signed-off-by: Connor Tsui <[email protected]>
1 parent b2cd767 commit da5d463

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

benchmarks/compress-bench/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ use ::vortex::array::arrays::ChunkedArray;
77
use ::vortex::array::arrays::recursive_list_from_list_view;
88
use arrow_array::RecordBatch;
99
use arrow_schema::Schema;
10-
10+
#[cfg(feature = "lance")]
11+
pub use lance_bench::compress::LanceCompressor;
1112
pub mod parquet;
1213
pub mod vortex;
1314

benchmarks/compress-bench/src/main.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ use std::path::PathBuf;
55
use std::time::Duration;
66

77
use clap::Parser;
8+
#[cfg(feature = "lance")]
9+
use compress_bench::LanceCompressor;
810
use compress_bench::parquet::ParquetCompressor;
911
use compress_bench::vortex::VortexCompressor;
1012
use indicatif::ProgressBar;
@@ -92,7 +94,7 @@ fn get_compressor(format: Format) -> Box<dyn Compressor> {
9294
Format::OnDiskVortex => Box::new(VortexCompressor),
9395
Format::Parquet => Box::new(ParquetCompressor::new()),
9496
#[cfg(feature = "lance")]
95-
Format::Lance => todo!(),
97+
Format::Lance => Box::new(LanceCompressor),
9698
_ => unimplemented!("Compress bench not implemented for {format}"),
9799
}
98100
}

0 commit comments

Comments
 (0)