feat[vector]: slice varbinview (#5697)

joseph-isaacs · web-flow · commit dc7f364f39d8 · 2025-12-11T17:41:28.000Z
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/vortex-vector/src/binaryview/vector.rs b/vortex-vector/src/binaryview/vector.rs
@@ -219,8 +219,13 @@ impl<T: BinaryViewType> VectorOps for BinaryViewVector<T> {
         BinaryViewScalar::<T>::new(self.get(index))
     }
 
-    fn slice(&self, _range: impl RangeBounds<usize> + Clone + Debug) -> Self {
-        todo!()
+    fn slice(&self, range: impl RangeBounds<usize> + Clone + Debug) -> Self {
+        BinaryViewVector {
+            views: self.views.slice(range.clone()),
+            buffers: self.buffers().clone(),
+            validity: self.validity.slice(range),
+            _marker: self._marker,
+        }
     }
 
     fn clear(&mut self) {

Original file line number	Diff line number	Diff line change
`@@ -219,8 +219,13 @@ impl<T: BinaryViewType> VectorOps for BinaryViewVector<T> {`
`219`	`219`	`BinaryViewScalar::<T>::new(self.get(index))`
`220`	`220`	`}`
`221`	`221`
`222`		`- fn slice(&self, _range: impl RangeBounds<usize> + Clone + Debug) -> Self {`
`223`		`- todo!()`
	`222`	`+ fn slice(&self, range: impl RangeBounds<usize> + Clone + Debug) -> Self {`
	`223`	`+ BinaryViewVector {`
	`224`	`+ views: self.views.slice(range.clone()),`
	`225`	`+ buffers: self.buffers().clone(),`
	`226`	`+ validity: self.validity.slice(range),`
	`227`	`+ _marker: self._marker,`
	`228`	`+ }`
`224`	`229`	`}`
`225`	`230`
`226`	`231`	`fn clear(&mut self) {`