u

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/arrays/dict/array.rs

@@ -124,7 +124,7 @@ pub struct DictArray {
     dtype: DType,
     /// Indicates whether all dictionary values are definitely referenced by at least one code.
     /// `true` = all values are referenced (computed during encoding).
-    /// `false` = unknown/might have unreferenced values (conservative default).
+    /// `false` = unknown/might have unreferenced values.
     all_values_referenced: bool,
 }
 

vortex-layout/src/layouts/dict/mod.rs

@@ -133,7 +133,7 @@ pub struct DictLayout {
     codes: LayoutRef,
     /// Indicates whether all dictionary values are definitely referenced by at least one code.
     /// `true` = all values are referenced (computed during encoding).
-    /// `false` = unknown/might have unreferenced values (conservative default).
+    /// `false` = unknown/might have unreferenced values.
     all_values_referenced: bool,
 }
 

vortex-layout/src/layouts/dict/reader.rs

@@ -201,7 +201,6 @@ impl LayoutReader for DictReader {
             let (values, codes) = try_join!(values_eval.map_err(VortexError::from), codes_eval)?;
 
             // Validate that codes are valid for the values
-            // Preserve all_values_referenced metadata from the layout
             let array =
                 DictArray::try_new_with_metadata(codes, values, all_values_referenced)?.to_array();
             expr.evaluate(&array)