Skip to content

Commit e1f3438

Browse files
committed
Only generate data if looking for local data
Signed-off-by: Adam Gutglick <[email protected]>
1 parent 250ecab commit e1f3438

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/sql-benchmarks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ jobs:
246246
OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}"
247247
OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}"
248248
OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}"
249-
RUST_LOG: "RUST_LOG=debug,vortex_io=off,hyper=off,datafusion=info,reqwest=off,sqlparser=off"
249+
RUST_LOG: "RUST_LOG=debug,vortex_io=off,hyper=off,datafusion=info,sqlparser=off"
250250
run: |
251251
# Extract formats for each engine
252252
df_formats=$(echo "${{ matrix.targets }}" | tr ',' '\n' | grep '^datafusion:' | sed 's/datafusion://' | tr '\n' ',' | sed 's/,$//')

benchmarks/ddb-bench/src/main.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,10 @@ async fn main() -> anyhow::Result<()> {
8383
args.exclude_queries.as_ref(),
8484
);
8585

86-
// Generate base Parquet data first - all formats derive from this
87-
benchmark.generate_base_data().await?;
88-
8986
// Generate Vortex files from Parquet for any Vortex formats requested
9087
if benchmark.data_url().scheme() == "file" {
88+
benchmark.generate_base_data().await?;
89+
9190
let base_path = benchmark
9291
.data_url()
9392
.to_file_path()

benchmarks/df-bench/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@ async fn main() -> anyhow::Result<()> {
109109
args.exclude_queries.as_ref(),
110110
);
111111

112-
benchmark.generate_base_data().await?;
113-
114112
// Generate Vortex files from Parquet for any Vortex formats requested
115113
if benchmark.data_url().scheme() == "file" {
114+
benchmark.generate_base_data().await?;
115+
116116
let base_path = benchmark
117117
.data_url()
118118
.to_file_path()

0 commit comments

Comments
 (0)