fix[dict]: min_max must not be null

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

fuzz/fuzz_targets/file_io.rs

@@ -100,12 +100,14 @@ fuzz_target!(|fuzz: FuzzFileAction| -> Corpus {
     assert_eq!(
         expected_array.len(),
         output_array.len(),
-        "Length was not preserved."
+        "Length was not preserved expected {} actual {}.",
+        expected_array.len(),
+        output_array.len()
     );
     assert_eq!(
         expected_array.dtype(),
         output_array.dtype(),
-        "DTypes aren't preserved expected {}, actual {}",
+        "DTypes aren't preserved expected {}, actual {}.",
         expected_array.dtype(),
         output_array.dtype()
     );

vortex-array/src/expr/exprs/get_item/mod.rs

@@ -80,7 +80,7 @@ impl VTable for GetItem {
     }
 
     fn fmt_data(&self, instance: &Self::Instance, f: &mut Formatter<'_>) -> std::fmt::Result {
-        write!(f, "\"{}\"", instance.inner().as_ref())
+        write!(f, "\"{}\"", instance)
     }
 
     fn return_dtype(&self, expr: &ExpressionView<Self>, scope: &DType) -> VortexResult<DType> {

vortex-array/src/mask_future.rs

@@ -68,6 +68,27 @@ impl MaskFuture {
         let inner = self.inner.clone();
         Self::new(range.len(), async move { Ok(inner.await?.slice(range)) })
     }
+
+    pub fn inspect(
+        self,
+        f: impl FnOnce(&SharedVortexResult<Mask>) + 'static + Send + Sync,
+    ) -> Self {
+        let len = self.len;
+
+        Self {
+            inner: self.inner
+                .inspect(f)
+                .inspect(move |r| {
+                    if let Ok(mask) = r
+                        && mask.len() != len {
+                        vortex_panic!("MaskFuture created with future that returned mask of incorrect length (expected {}, got {})", len, mask.len());
+                    }
+                })
+                .boxed()
+                .shared(),
+            len,
+        }
+    }
 }
 
 impl Future for MaskFuture {

vortex-layout/src/layouts/dict/reader.rs

@@ -174,12 +174,14 @@ impl LayoutReader for DictReader {
             let mask = mask.await?;
 
             // Short-circuit when the values are all true/false.
-            if let Some(MinMaxResult { min, max }) = min_max(&values)? {
-                if !max.as_bool().value().unwrap_or(true) {
+            if values.all_valid()
+                && let Some(MinMaxResult { min, max }) = min_max(&values)?
+            {
+                if max.as_bool().value().vortex_expect("non null") == false {
                     // All values are false
                     return Ok(Mask::AllFalse(mask.len()));
                 }
-                if min.as_bool().value().unwrap_or(false) {
+                if min.as_bool().value().vortex_expect("not null") == true {
                     // All values are true, but we still need to respect codes validity
                     return Ok(mask.bitand(&codes.validity_mask()));
                 }