Fix: decimal cast error message (#5821)

This should also make sure that the fuzzer doesn't keep reporting the
wrong error message.

As for the TODO, see #5820

Signed-off-by: Connor Tsui <[email protected]>

Author: connortsui20

vortex-array/src/arrays/decimal/compute/fill_null.rs

@@ -28,11 +28,13 @@ impl FillNullKernel for DecimalVTable {
                 let is_invalid = is_valid.to_bool().bit_buffer().not();
                 match_each_decimal_value_type!(array.values_type(), |T| {
                     let mut buffer = array.buffer::<T>().into_mut();
-                    let fill_value = fill_value
-                        .as_decimal()
+                    let decimal_scalar = fill_value.as_decimal();
+                    let decimal_value = decimal_scalar
                         .decimal_value()
-                        .and_then(|v| v.cast::<T>())
-                        .vortex_expect("top-level fill_null ensure non-null fill value");
+                        .vortex_expect("fill_null requires a non-null fill value");
+                    let fill_value = decimal_value
+                        .cast::<T>()
+                        .vortex_expect("fill value does not fit in array's decimal storage type");
                     for invalid_index in is_invalid.set_indices() {
                         buffer[invalid_index] = fill_value;
                     }

vortex-array/src/compute/fill_null.rs

@@ -59,6 +59,14 @@ pub fn fill_null(array: &dyn Array, fill_value: &Scalar) -> VortexResult<ArrayRe
 }
 
 pub trait FillNullKernel: VTable {
+    /// Kernel for replacing null values in an array with a fill value.
+    ///
+    /// TODO(connor): Actually enforce these constraints (so that casts do not fail).
+    ///
+    /// Implementations can assume that:
+    /// - The array has at least one null value (not all valid, not all invalid).
+    /// - The fill value is non-null.
+    /// - For decimal arrays, the fill value can be successfully cast to the array's storage type.
     fn fill_null(&self, array: &Self::Array, fill_value: &Scalar) -> VortexResult<ArrayRef>;
 }