Skip to content

Commit e31512d

Browse files
authored
bench: enable divan codspeed compatibility layer (#2351)
1 parent 7e96d79 commit e31512d

File tree

4 files changed

+53
-53
lines changed

4 files changed

+53
-53
lines changed

.github/workflows/bench-pr.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,6 @@ jobs:
2525
codspeed_bench:
2626
name: Run Criterion benchmarks with Codspeed
2727
needs: label_trigger
28-
env:
29-
# TODO(joe): replace this list with a off-list instead of the current on-list.
30-
BENCH_TARGETS: >
31-
dict_compare
32-
dict_compress
33-
chunked_dict_array_builder
34-
bitpacking_take
35-
run_end_filter
36-
run_end_null_count
37-
search_sorted
38-
scalar_subtract
39-
compare
40-
take_strings
41-
take_patches
4228
runs-on: ubuntu-latest
4329
steps:
4430
- uses: actions/checkout@v4
@@ -54,12 +40,12 @@ jobs:
5440
RUSTFLAGS: "-C target-cpu=native"
5541
# We want to run micro-benchmarks with release profile.
5642
# We run with all features since we feature gate bench utils.
57-
run: cargo codspeed build --features test-harness --profile release $BENCH_TARGETS
43+
run: cargo codspeed build --exclude bench-vortex --workspace --profile release
5844

5945
- name: Run the benchmarks
6046
uses: CodSpeedHQ/action@v3
6147
with:
62-
run: cargo codspeed run $BENCH_TARGETS
48+
run: cargo codspeed run
6349
token: ${{ secrets.CODSPEED_TOKEN }}
6450

6551
bench:

.github/workflows/bench.yml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,6 @@ jobs:
3232
3333
codspeed_bench:
3434
name: Run Criterion benchmarks with Codspeed
35-
env:
36-
BENCH_TARGETS: >
37-
dict_compare
38-
dict_compress
39-
bitpacking_take
40-
run_end_filter
41-
run_end_null_count
42-
search_sorted
43-
scalar_subtract
44-
compare
45-
take_strings
46-
take_patches
4735
runs-on: ubuntu-latest
4836
steps:
4937
- uses: actions/checkout@v4
@@ -57,14 +45,14 @@ jobs:
5745
- name: Build benchmark targets
5846
env:
5947
RUSTFLAGS: "-C target-cpu=native"
60-
# The profile needs to be set explicitly to bench
61-
# as codspeed by default compiles with the release profile.
62-
run: cargo codspeed build --profile bench $BENCH_TARGETS
48+
# We want to run micro-benchmarks with release profile.
49+
# We run with all features since we feature gate bench utils.
50+
run: cargo codspeed build --exclude bench-vortex --workspace --profile release
6351

6452
- name: Run the benchmarks
6553
uses: CodSpeedHQ/action@v3
6654
with:
67-
run: cargo codspeed run $BENCH_TARGETS
55+
run: cargo codspeed run
6856
token: ${{ secrets.CODSPEED_TOKEN }}
6957

7058
bench:

Cargo.lock

Lines changed: 46 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ datafusion-execution = "45"
8080
datafusion-expr = "45"
8181
datafusion-physical-expr = "45"
8282
datafusion-physical-plan = "45"
83-
divan = "0.1.14"
83+
divan = { package = "codspeed-divan-compat", version = "2.8.0" }
8484
dyn-hash = "0.2.0"
8585
enum-iterator = "2.0.0"
8686
exponential-decay-histogram = "=0.1.11"

0 commit comments

Comments
 (0)