Skip to content

Commit e34e64e

Browse files
Fix compilation and formatting issues in ListViewArray test
- Remove incorrect .unwrap() call on ListViewArray::new (returns Self, not Result) - Fix formatting to match nightly fmt requirements 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Joe Isaacs <[email protected]>
1 parent 9466616 commit e34e64e

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

vortex-layout/src/layouts/compact.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,17 @@ impl CompactCompressor {
146146
let sizes_ptype = narrowed_sizes.ptype();
147147
let offsets_ptype = narrowed_offsets.ptype();
148148

149-
let (final_offsets, final_sizes) = if sizes_ptype.byte_width() > offsets_ptype.byte_width() {
150-
// Cast offsets to match sizes type
151-
let casted_offsets = vortex_array::compute::cast(
152-
&narrowed_offsets.into_array(),
153-
narrowed_sizes.dtype(),
154-
)?;
155-
(casted_offsets, narrowed_sizes.into_array())
156-
} else {
157-
(narrowed_offsets.into_array(), narrowed_sizes.into_array())
158-
};
149+
let (final_offsets, final_sizes) =
150+
if sizes_ptype.byte_width() > offsets_ptype.byte_width() {
151+
// Cast offsets to match sizes type
152+
let casted_offsets = vortex_array::compute::cast(
153+
&narrowed_offsets.into_array(),
154+
narrowed_sizes.dtype(),
155+
)?;
156+
(casted_offsets, narrowed_sizes.into_array())
157+
} else {
158+
(narrowed_offsets.into_array(), narrowed_sizes.into_array())
159+
};
159160

160161
let compressed_offsets = self.compress(&final_offsets)?;
161162
let compressed_sizes = self.compress(&final_sizes)?;
@@ -300,8 +301,7 @@ mod tests {
300301
)
301302
.into_array();
302303

303-
let listview =
304-
ListViewArray::new(elements.clone(), offsets, sizes, Validity::NonNullable).unwrap();
304+
let listview = ListViewArray::new(elements.clone(), offsets, sizes, Validity::NonNullable);
305305

306306
// This should not panic - the fix ensures compatible types
307307
let compressed = compressor.compress(listview.as_ref()).unwrap();

0 commit comments

Comments
 (0)