wip datetimeparts fixes

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

bench-vortex/Cargo.toml

@@ -73,7 +73,7 @@ tokio-stream = { workspace = true }
 tokio-util = { workspace = true }
 tpchgen = { workspace = true }
 tpchgen-arrow = { workspace = true }
-tracing = { workspace = true, features = ["max_level_trace"] }
+tracing = { workspace = true, features = ["max_level_debug"] }
 tracing-perfetto = { workspace = true }
 tracing-subscriber = { workspace = true, features = [
     "env-filter",

vortex-array/src/arrays/datetime/mod.rs

@@ -201,6 +201,12 @@ impl TemporalArray {
     }
 }
 
+impl AsRef<dyn Array> for TemporalArray {
+    fn as_ref(&self) -> &dyn Array {
+        self.ext.as_ref()
+    }
+}
+
 impl From<TemporalArray> for ArrayRef {
     fn from(value: TemporalArray) -> Self {
         value.ext.into_array()

vortex-array/src/expr/transform/partition.rs

@@ -71,7 +71,7 @@ where
             Nullability::NonNullable,
         );
 
-        // let expr = expr.optimize_recursive(scope)?;
+        let expr = expr.optimize_recursive(scope)?;
         let expr_dtype = expr.return_dtype(scope)?;
 
         partitions.push(expr);

vortex-btrblocks/src/lib.rs

@@ -477,13 +477,9 @@ impl BtrBlocksCompressor {
                 if let Ok(temporal_array) = TemporalArray::try_from(ext_array.to_array())
                     && let TemporalMetadata::Timestamp(..) = temporal_array.temporal_metadata()
                 {
-                    let temporal_array_ref = temporal_array.clone().into_array();
-                    if temporal_array_ref
-                        .as_ref()
-                        .is_constant_opts(Cost::Canonicalize)
-                    {
+                    if temporal_array.as_ref().is_constant_opts(Cost::Canonicalize) {
                         return Ok(ConstantArray::new(
-                            temporal_array_ref.scalar_at(0),
+                            temporal_array.as_ref().scalar_at(0),
                             ext_array.len(),
                         )
                         .into_array());