Skip to content

Commit e664eb8

Browse files
committed
Add more arrow execution
Signed-off-by: Nicholas Gates <[email protected]>
1 parent 548ac4e commit e664eb8

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

vortex-array/src/executor.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ impl VectorExecutor for ArrayRef {
3333
// NOTE(ngates): in the future we can choose a different mode of execution, or run
3434
// optimization here, etc.
3535
let kernel = self.bind_kernel(&mut ctx)?;
36+
tracing::debug!("Executing kernel:\n{:#?}", kernel);
3637
let result = kernel.execute()?;
3738

3839
vortex_ensure!(

vortex-array/src/expr/vtable.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,16 +177,16 @@ pub trait VTable: 'static + Sized + Send + Sync {
177177
/// An expression is null-sensitive if it directly operates on null values,
178178
/// such as `is_null`. Most expressions are not null-sensitive.
179179
///
180-
/// The property we are interested in is if the expression (e) distributes over
181-
/// mask.
180+
/// The property we are interested in is if the expression (e) distributes over `mask`.
182181
/// Define a `mask(a, m)` expression that applies the boolean array `m` to the validity of the
183182
/// array `a`.
184-
/// An unary expression `e` to be null-sensitive iff forall arrays `a` and masks `m`.
183+
///
184+
/// A unary expression `e` is not null-sensitive iff forall arrays `a` and masks `m`,
185185
/// `e(mask(a, m)) == mask(e(a), m)`.
186+
///
186187
/// This can be extended to an n-ary expression.
187188
///
188-
/// This method only checks the expression itself, not its children. To check
189-
/// if an expression or any of its descendants are null-sensitive.
189+
/// This method only checks the expression itself, not its children.
190190
fn is_null_sensitive(&self, options: &Self::Options) -> bool {
191191
_ = options;
192192
true

0 commit comments

Comments
 (0)