display metrics for clickbench (#2682)

Author: onursatici

bench-vortex/src/bin/clickbench.rs

@@ -4,7 +4,7 @@ use std::time::{Duration, Instant};
 use bench_vortex::clickbench::{self, Flavor, HITS_SCHEMA, clickbench_queries};
 use bench_vortex::display::{DisplayFormat, RatioMode, print_measurements_json, render_table};
 use bench_vortex::measurements::QueryMeasurement;
-use bench_vortex::metrics::export_plan_spans;
+use bench_vortex::metrics::{MetricsSetExt, export_plan_spans};
 use bench_vortex::{
     Format, IdempotentPath as _, default_env_filter, execute_physical_plan,
     feature_flagged_allocator, get_session_with_cache, physical_plan,
@@ -18,6 +18,7 @@ use tokio::runtime::Builder;
 use tracing::info_span;
 use tracing_futures::Instrument;
 use vortex::error::vortex_panic;
+use vortex_datafusion::persistent::metrics::VortexMetricsFinder;
 
 feature_flagged_allocator!();
 
@@ -112,6 +113,7 @@ fn main() -> anyhow::Result<()> {
 
     let mut all_measurements = Vec::default();
 
+    let mut metrics = Vec::new();
     for format in &args.formats {
         let session_context = get_session_with_cache(args.emulate_object_store);
         let context = session_context.clone();
@@ -177,8 +179,8 @@ fn main() -> anyhow::Result<()> {
             }
             progress_bar.inc(1);
 
+            let plan = last_plan.expect("must have at least one iteration");
             if args.emit_plan {
-                let plan = last_plan.expect("must have at least one iteration");
                 fs::write(
                     format!("clickbench_{format}_q{query_idx:02}.plan",),
                     format!("{:#?}", plan),
@@ -197,7 +199,11 @@ fn main() -> anyhow::Result<()> {
                 )
                 .expect("Unable to write file");
             }
-
+            metrics.push((
+                query_idx,
+                format,
+                VortexMetricsFinder::find_all(plan.as_ref()),
+            ));
             all_measurements.push(QueryMeasurement {
                 query_idx,
                 storage: "nvme".to_string(),
@@ -216,6 +222,21 @@ fn main() -> anyhow::Result<()> {
 
     match args.display_format {
         DisplayFormat::Table => {
+            for (query, format, metric_sets) in metrics {
+                println!();
+                println!("metrics for query={query}, {format}:");
+                for (idx, metric_set) in metric_sets.into_iter().enumerate() {
+                    println!("scan[{idx}]:");
+                    for m in metric_set
+                        .timestamps_removed()
+                        .aggregate()
+                        .sorted_for_display()
+                        .iter()
+                    {
+                        println!("{}", m);
+                    }
+                }
+            }
             render_table(all_measurements, &args.formats, RatioMode::Time).unwrap()
         }
         DisplayFormat::GhJson => print_measurements_json(all_measurements).unwrap(),