chore: Rename CheckedAdd operator to Add (#3612)

Signed-off-by: Robert Kruszewski <[email protected]>

Author: robert3005

vortex-expr/src/exprs/binary.rs

@@ -119,7 +119,7 @@ impl AnalysisExpr for BinaryExpr {
                 self.lhs.stat_falsification(catalog)?,
                 self.rhs.stat_falsification(catalog)?,
             )),
-            Operator::CheckedAdd => None,
+            Operator::Add => None,
         }
     }
 }
@@ -142,7 +142,7 @@ impl VortexExpr for BinaryExpr {
             Operator::Gte => compare(&lhs, &rhs, ArrayOperator::Gte),
             Operator::And => and_kleene(&lhs, &rhs),
             Operator::Or => or_kleene(&lhs, &rhs),
-            Operator::CheckedAdd => add(&lhs, &rhs),
+            Operator::Add => add(&lhs, &rhs),
         }
     }
 
@@ -159,7 +159,7 @@ impl VortexExpr for BinaryExpr {
         let lhs = self.lhs.return_dtype(ctx)?;
         let rhs = self.rhs.return_dtype(ctx)?;
 
-        if self.operator == Operator::CheckedAdd {
+        if self.operator == Operator::Add {
             if lhs.is_primitive() && lhs.eq_ignore_nullability(&rhs) {
                 return Ok(lhs.with_nullability(lhs.nullability() | rhs.nullability()));
             }
@@ -414,7 +414,7 @@ where
 /// );
 /// ```
 pub fn checked_add(lhs: ExprRef, rhs: ExprRef) -> ExprRef {
-    BinaryExpr::new_expr(lhs, Operator::CheckedAdd, rhs)
+    BinaryExpr::new_expr(lhs, Operator::Add, rhs)
 }
 
 #[cfg(test)]

vortex-expr/src/exprs/operators.rs

@@ -22,7 +22,7 @@ pub enum Operator {
     /// Errs at runtime if the sum would overflow or underflow.
     ///
     /// The result is null at any index that either input is null.
-    CheckedAdd,
+    Add,
 }
 
 #[cfg(feature = "proto")]
@@ -50,7 +50,7 @@ mod proto {
                 Operator::Lte => BinaryOp::Lte,
                 Operator::And => BinaryOp::And,
                 Operator::Or => BinaryOp::Or,
-                Operator::CheckedAdd => BinaryOp::CheckedAdd,
+                Operator::Add => BinaryOp::Add,
             }
         }
     }
@@ -74,7 +74,7 @@ mod proto {
                 BinaryOp::Lte => Operator::Lte,
                 BinaryOp::And => Operator::And,
                 BinaryOp::Or => Operator::Or,
-                BinaryOp::CheckedAdd => Operator::CheckedAdd,
+                BinaryOp::Add => Operator::Add,
             }
         }
     }
@@ -91,7 +91,7 @@ impl Display for Operator {
             Operator::Lte => "<=",
             Operator::And => "and",
             Operator::Or => "or",
-            Operator::CheckedAdd => "+w",
+            Operator::Add => "+w",
         };
         Display::fmt(display, f)
     }
@@ -106,7 +106,7 @@ impl Operator {
             Operator::Gte => Some(Operator::Lt),
             Operator::Lt => Some(Operator::Gte),
             Operator::Lte => Some(Operator::Gt),
-            Operator::And | Operator::Or | Operator::CheckedAdd => None,
+            Operator::And | Operator::Or | Operator::Add => None,
         }
     }
 
@@ -129,7 +129,7 @@ impl Operator {
             Operator::Lte => Operator::Gte,
             Operator::And => Operator::And,
             Operator::Or => Operator::Or,
-            Operator::CheckedAdd => Operator::CheckedAdd,
+            Operator::Add => Operator::Add,
         }
     }
 

vortex-expr/src/forms/nnf.rs

@@ -115,7 +115,7 @@ impl FolderMut for NNFVisitor {
                     Operator::Lte => Operator::Gt,
                     Operator::And => Operator::Or,
                     Operator::Or => Operator::And,
-                    Operator::CheckedAdd => {
+                    Operator::Add => {
                         vortex_bail!("nnf: type mismatch: cannot negate addition")
                     }
                 };

vortex-proto/proto/expr.proto

@@ -71,7 +71,7 @@ message Kind {
     Lte = 5;
     And = 6;
     Or = 7;
-    CheckedAdd = 8;
+    Add = 8;
   }
 
   message Between {

vortex-proto/src/generated/vortex.expr.rs

@@ -89,7 +89,7 @@ pub mod kind {
         Lte = 5,
         And = 6,
         Or = 7,
-        CheckedAdd = 8,
+        Add = 8,
     }
     impl BinaryOp {
         /// String value of the enum field names used in the ProtoBuf definition.
@@ -106,7 +106,7 @@ pub mod kind {
                 Self::Lte => "Lte",
                 Self::And => "And",
                 Self::Or => "Or",
-                Self::CheckedAdd => "CheckedAdd",
+                Self::Add => "Add",
             }
         }
         /// Creates an enum from field names used in the ProtoBuf definition.
@@ -120,7 +120,7 @@ pub mod kind {
                 "Lte" => Some(Self::Lte),
                 "And" => Some(Self::And),
                 "Or" => Some(Self::Or),
-                "CheckedAdd" => Some(Self::CheckedAdd),
+                "Add" => Some(Self::Add),
                 _ => None,
             }
         }