Support bring-your-own-key

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-array/src/arrays/chunked/vtable/mod.rs

@@ -6,20 +6,20 @@ use vortex_buffer::BufferHandle;
 use vortex_dtype::DType;
 use vortex_dtype::Nullability;
 use vortex_dtype::PType;
-use vortex_error::VortexResult;
 use vortex_error::vortex_bail;
 use vortex_error::vortex_err;
+use vortex_error::VortexResult;
+use vortex_mask::Mask;
 use vortex_vector::Vector;
 use vortex_vector::VectorMut;
 use vortex_vector::VectorMutOps;
 
-use crate::EmptyMetadata;
-use crate::ToCanonical;
 use crate::arrays::ChunkedArray;
 use crate::arrays::PrimitiveArray;
 use crate::kernel::BindCtx;
 use crate::kernel::Kernel;
 use crate::kernel::KernelRef;
+use crate::kernel::PushDownResult;
 use crate::serde::ArrayChildren;
 use crate::validity::Validity;
 use crate::vtable;
@@ -28,6 +28,8 @@ use crate::vtable::ArrayVTable;
 use crate::vtable::ArrayVTableExt;
 use crate::vtable::NotSupported;
 use crate::vtable::VTable;
+use crate::EmptyMetadata;
+use crate::ToCanonical;
 
 mod array;
 mod canonical;
@@ -157,4 +159,8 @@ impl Kernel for ChunkedKernel {
         }
         Ok(vector.freeze())
     }
+
+    fn push_down_filter(self: Box<Self>, _selection: &Mask) -> VortexResult<PushDownResult> {
+        Ok(PushDownResult::NotPushed(self))
+    }
 }

vortex-array/src/kernel/closure.rs

@@ -5,10 +5,12 @@ use std::fmt::Debug;
 use std::fmt::Formatter;
 
 use vortex_error::VortexResult;
+use vortex_mask::Mask;
 use vortex_vector::Vector;
 
 use crate::kernel::Kernel;
 use crate::kernel::KernelRef;
+use crate::kernel::PushDownResult;
 
 /// Create a kernel from a closure.
 pub fn kernel<F: FnOnce() -> VortexResult<Vector> + Send + 'static>(closure: F) -> KernelRef {
@@ -29,4 +31,8 @@ impl<F: FnOnce() -> VortexResult<Vector> + Send + 'static> Kernel for ClosureKer
     fn execute(self: Box<Self>) -> VortexResult<Vector> {
         (self.closure)()
     }
+
+    fn push_down_filter(self: Box<Self>, _selection: &Mask) -> VortexResult<PushDownResult> {
+        Ok(PushDownResult::NotPushed(self))
+    }
 }

vortex-array/src/kernel/mod.rs

@@ -40,10 +40,7 @@ pub trait Kernel: 'static + Send + Debug {
     /// Push a selection mask through this kernel.
     ///
     /// Return `Ok(None)` if the filter cannot be pushed down.
-    fn push_down_filter(self: Box<Self>, selection: &Mask) -> VortexResult<PushDownResult> {
-        _ = selection;
-        Ok(PushDownResult::NotPushed(self))
-    }
+    fn push_down_filter(self: Box<Self>, selection: &Mask) -> VortexResult<PushDownResult>;
 }
 
 pub enum PushDownResult {

vortex-array/src/kernel/ready.rs

@@ -7,6 +7,7 @@ use vortex_vector::Vector;
 
 use crate::kernel::Kernel;
 use crate::kernel::KernelRef;
+use crate::kernel::PushDownResult;
 
 /// Create a kernel that is already computed and ready.
 pub fn ready(vector: Vector) -> KernelRef {
@@ -32,4 +33,8 @@ impl Kernel for ReadyKernel {
         _ = selection;
         0.0
     }
+
+    fn push_down_filter(self: Box<Self>, _selection: &Mask) -> VortexResult<PushDownResult> {
+        Ok(PushDownResult::NotPushed(self))
+    }
 }