Skip to content

Commit ee7cb6b

Browse files
committed
Clarify docs in session accessors
Signed-off-by: Nicholas Gates <[email protected]>
1 parent fff402a commit ee7cb6b

File tree

1 file changed

+0
-38
lines changed

1 file changed

+0
-38
lines changed

vortex-array/src/expr/exprs/get_item.rs

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ use crate::expr::ExecutionArgs;
2727
use crate::expr::ExprId;
2828
use crate::expr::Expression;
2929
use crate::expr::Pack;
30-
use crate::expr::SimplifyCtx;
3130
use crate::expr::StatsCatalog;
3231
use crate::expr::VTable;
3332
use crate::expr::VTableExt;
@@ -136,43 +135,6 @@ impl VTable for GetItem {
136135
}
137136
}
138137

139-
fn simplify(
140-
&self,
141-
field_name: &FieldName,
142-
expr: &Expression,
143-
ctx: &dyn SimplifyCtx,
144-
) -> VortexResult<Option<Expression>> {
145-
let child = expr.child(0);
146-
let child_dtype = ctx.return_dtype(child)?;
147-
148-
// If the child is a Pack expression, we can directly return the corresponding child.
149-
if let Some(pack) = child.as_opt::<Pack>() {
150-
let idx = pack
151-
.names
152-
.iter()
153-
.position(|name| name == field_name)
154-
.ok_or_else(|| {
155-
vortex_err!(
156-
"Cannot find field {} in pack fields {:?}",
157-
field_name,
158-
pack.names
159-
)
160-
})?;
161-
162-
let mut field = child.child(idx).clone();
163-
164-
// If the pack expression is nullable but the child field is not, we need to
165-
// adjust the nullability of the resulting expression.
166-
if pack.nullability.is_nullable() && !child_dtype.is_nullable() {
167-
field = field.cast(child_dtype.as_nullable())?;
168-
}
169-
170-
return Ok(Some(field));
171-
}
172-
173-
Ok(None)
174-
}
175-
176138
fn simplify_untyped(
177139
&self,
178140
field_name: &FieldName,

0 commit comments

Comments
 (0)