Decimal Vector

Signed-off-by: Nicholas Gates <[email protected]>

Author: gatesn

vortex-dtype/src/decimal/max_precision.rs

@@ -1,6 +1,9 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+//! Lookup tables for minumum/maximum i256 decimal values for each precision.
+//! We cannot perform const computations for i256, so we precompute these values.
+
 use crate::i256;
 
 pub(super) const MAX_DECIMAL256_FOR_EACH_PRECISION: [i256; 77] = [

vortex-dtype/src/decimal/types.rs

@@ -117,8 +117,8 @@ macro_rules! impl_decimal {
                 const DECIMAL_TYPE: DecimalType = DecimalType::$UPPER;
 
                 const MAX_PRECISION: u8 = match DecimalType::$UPPER {
-                    DecimalType::I8 => 3,
-                    DecimalType::I16 => 5,
+                    DecimalType::I8 => 2,
+                    DecimalType::I16 => 4,
                     DecimalType::I32 => 9,
                     DecimalType::I64 => 18,
                     DecimalType::I128 => 38,
@@ -131,8 +131,8 @@ macro_rules! impl_decimal {
                     let mut p = $T::ONE;
                     let mut i = 0;
                     while i < Self::MAX_PRECISION as usize {
-                        mins[i] = -((p * 10) - 1);
-                        p = p * (10 as $T);
+                        p = p * 10;
+                        mins[i] = -(p - 1);
                         i += 1;
                     }
                     mins
@@ -143,8 +143,8 @@ macro_rules! impl_decimal {
                     let mut p = $T::ONE;
                     let mut i = 0;
                     while i < Self::MAX_PRECISION as usize {
-                        maxs[i] = (p * 10) - 1;
-                        p = p * (10 as $T);
+                        p = p * 10;
+                        maxs[i] = p - 1;
                         i += 1;
                     }
                     maxs

vortex-vector/src/decimal/macros.rs

@@ -43,30 +43,12 @@
 macro_rules! match_each_dvector {
     ($self:expr, | $vec:ident | $body:block) => {{
         match $self {
-            $crate::DecimalVector::D8(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVector::D16(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVector::D32(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVector::D64(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVector::D128(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVector::D256(v) => {
-                let $vec = v;
-                $body
-            }
+            $crate::DecimalVector::D8($vec) => $body,
+            $crate::DecimalVector::D16($vec) => $body,
+            $crate::DecimalVector::D32($vec) => $body,
+            $crate::DecimalVector::D64($vec) => $body,
+            $crate::DecimalVector::D128($vec) => $body,
+            $crate::DecimalVector::D256($vec) => $body,
         }
     }};
 }
@@ -105,30 +87,12 @@ macro_rules! match_each_dvector {
 macro_rules! match_each_dvector_mut {
     ($self:expr, | $vec:ident | $body:block) => {{
         match $self {
-            $crate::DecimalVectorMut::D8(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVectorMut::D16(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVectorMut::D32(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVectorMut::D64(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVectorMut::D128(v) => {
-                let $vec = v;
-                $body
-            }
-            $crate::DecimalVectorMut::D256(v) => {
-                let $vec = v;
-                $body
-            }
+            $crate::DecimalVectorMut::D8($vec) => $body,
+            $crate::DecimalVectorMut::D16($vec) => $body,
+            $crate::DecimalVectorMut::D32($vec) => $body,
+            $crate::DecimalVectorMut::D64($vec) => $body,
+            $crate::DecimalVectorMut::D128($vec) => $body,
+            $crate::DecimalVectorMut::D256($vec) => $body,
         }
     }};
 }