not

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-array/src/expr/exprs/is_null.rs

@@ -3,7 +3,7 @@
 
 use std::fmt::Formatter;
 use std::ops::Not;
-
+use is_null::IsNullFn;
 use vortex_dtype::DType;
 use vortex_dtype::Nullability;
 use vortex_error::VortexExpect;
@@ -115,7 +115,7 @@ impl VTable for IsNull {
     }
 
     fn expr_v2(&self, view: &ExpressionView<Self>) -> VortexResult<Expression> {
-        ScalarFnExprExt::try_new_expr(&is_null::IsNull, EmptyOptions, view.children().clone())
+        ScalarFnExprExt::try_new_expr(&IsNullFn, EmptyOptions, view.children().clone())
     }
 }
 

vortex-array/src/expr/vtable.rs

@@ -156,6 +156,7 @@ pub trait VTable: 'static + Sized + Send + Sync {
 
     /// **For internal usage**. This will return an Expression that is part of the
     /// expression -> new_expression migration.
+    #[doc(hidden)]
     fn expr_v2(&self, expr: &ExpressionView<Self>) -> VortexResult<Expression> {
         Ok(expr.deref().clone())
     }

vortex-array/src/scalar_fns/is_null/mod.rs

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 // SPDX-FileCopyrightText: Copyright the Vortex contributors
 
+use std::ops::Not;
 use vortex_dtype::DType;
 use vortex_dtype::Nullability::NonNullable;
 use vortex_error::VortexResult;
@@ -19,8 +20,8 @@ use crate::expr::functions::EmptyOptions;
 use crate::expr::functions::ExecutionArgs;
 use crate::expr::functions::VTable;
 
-pub struct IsNull;
-impl VTable for IsNull {
+pub struct IsNullFn;
+impl VTable for IsNullFn {
     type Options = EmptyOptions;
 
     fn id(&self) -> ExprId {
@@ -46,7 +47,7 @@ impl VTable for IsNull {
         Ok(match args.input_datums(0) {
             Datum::Scalar(sc) => Datum::Scalar(sc.is_invalid().into()),
             Datum::Vector(vec) => Vector::Bool(BoolVector::new(
-                vec.validity().to_bit_buffer(),
+                vec.validity().to_bit_buffer().not(),
                 Mask::AllTrue(vec.len()),
             ))
             .into(),