fix: Adjust the constant optimization in list_contains (#3211)

The constant optimization in `list_contains` was incorrect (and could
cause a crash like #3210), because it:
1. produced a `ConstantArray` with the length of the `elements` array,
rather than with the length of the input `ListArray`.
2. produced a `ConstantArray(true)` when all `elements` matched, without
correlating with the `offsets` (which might contain empty lists).

This change adjusts the constant optimization to only trigger if no
elements match, and to produce a `ConstantArray` of the appropriate
length.

Fixes #3210.

Author: stuhood

vortex-array/src/compute/list.rs

@@ -62,13 +62,12 @@ pub fn list_contains(array: &dyn Array, value: Scalar) -> VortexResult<ArrayRef>
     let matching_elements = compare(elems, &rhs, Operator::Eq)?;
     let matches = matching_elements.to_bool()?;
 
-    // Fast path: all elements match or none match.
+    // Fast path: no elements match.
     if let Some(pred) = matches.as_constant() {
-        return match pred.as_bool().value() {
+        if matches!(pred.as_bool().value(), None | Some(false)) {
             // TODO(aduffy): how do we handle null?
-            None | Some(false) => Ok(ConstantArray::new::<bool>(false, matches.len()).into_array()),
-            Some(true) => Ok(ConstantArray::new::<bool>(true, matches.len()).into_array()),
-        };
+            return Ok(ConstantArray::new::<bool>(false, list_array.len()).into_array());
+        }
     }
 
     match_each_integer_ptype!(ends.ptype(), |$T| {
@@ -251,6 +250,24 @@ mod tests {
         None,
         bool_array(vec![false, true, true], None)
     )]
+    // Case 3: list(utf8) with all elements matching, but some empty lists
+    #[case(
+        nonnull_strings(vec![vec![], vec!["a"], vec!["a"]]),
+        Some("a"),
+        bool_array(vec![false, true, true], None)
+    )]
+    // Case 4: list(utf8) all lists empty.
+    #[case(
+        nonnull_strings(vec![vec![], vec![], vec![]]),
+        Some("a"),
+        bool_array(vec![false, false, false], None)
+    )]
+    // Case 5: list(utf8) no elements matching.
+    #[case(
+        nonnull_strings(vec![vec!["b"], vec![], vec!["b"]]),
+        Some("a"),
+        bool_array(vec![false, false, false], None)
+    )]
     fn test_contains_nullable(
         #[case] list_array: ArrayRef,
         #[case] value: Option<&str>,