Skip to content

Commit fda14c1

Browse files
committed
fix tests
Signed-off-by: Andrew Duffy <[email protected]>
1 parent a562994 commit fda14c1

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

vortex-datafusion/src/convert/exprs.rs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -508,8 +508,7 @@ mod tests {
508508
DataType::List(Arc::new(Field::new("item", DataType::Int32, true))),
509509
false
510510
)]
511-
#[case::struct_type(DataType::Struct(vec![Field::new("field", DataType::Int32, true)].into()
512-
), false)]
511+
#[case::struct_type(DataType::Struct(vec![Field::new("field", DataType::Int32, true)].into()), true)]
513512
// Dictionary types - should be supported if value type is supported
514513
#[case::dict_utf8(
515514
DataType::Dictionary(Box::new(DataType::UInt32), Box::new(DataType::Utf8)),
@@ -681,9 +680,11 @@ mod tests {
681680
let source = vortex_source(&test_schema);
682681

683682
let prop = source
684-
.try_pushdown_filters(vec![physical_filter], &ConfigOptions::default())
683+
.try_pushdown_filters(vec![physical_filter.clone()], &ConfigOptions::default())
685684
.unwrap();
686-
assert!(matches!(prop.filters[0], PushedDown::Yes));
685+
let updated_source = prop.updated_node.unwrap();
686+
let pushed_filters = updated_source.filter();
687+
assert_eq!(pushed_filters, Some(physical_filter))
687688
}
688689

689690
#[test]
@@ -715,9 +716,11 @@ mod tests {
715716
let physical_filter = logical2physical(&deep_filter, df_schema.as_ref());
716717

717718
let prop = source
718-
.try_pushdown_filters(vec![physical_filter], &ConfigOptions::default())
719+
.try_pushdown_filters(vec![physical_filter.clone()], &ConfigOptions::default())
719720
.unwrap();
720-
assert!(matches!(prop.filters[0], PushedDown::Yes));
721+
let updated_source = prop.updated_node.unwrap();
722+
let pushed_filters = updated_source.filter();
723+
assert_eq!(pushed_filters, Some(physical_filter))
721724
}
722725

723726
#[test]

0 commit comments

Comments
 (0)