fix: accum zero

robert3005 · robert3005 · commit fe841911be7e · 2025-11-24T16:57:23.000Z
Signed-off-by: Robert Kruszewski &lt;github@robertk.io&gt;
diff --git a/vortex-array/src/compute/sum.rs b/vortex-array/src/compute/sum.rs
@@ -106,7 +106,7 @@ impl ComputeFnVTable for Sum {
             // For floats only use stats if accumulator is zero. otherwise we might have numerical stability issues.
             match sum_dtype {
                 DType::Primitive(p, _) => {
-                    if p.is_float() {
+                    if p.is_float() && accumulator.is_zero() {
                         return Ok(sum.into());
                     }
                     let sum_from_stat = accumulator

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ impl ComputeFnVTable for Sum {`
`106`	`106`	`// For floats only use stats if accumulator is zero. otherwise we might have numerical stability issues.`
`107`	`107`	`match sum_dtype {`
`108`	`108`	`DType::Primitive(p, _) => {`
`109`		`- if p.is_float() {`
	`109`	`+ if p.is_float() && accumulator.is_zero() {`
`110`	`110`	`return Ok(sum.into());`
`111`	`111`	`}`
`112`	`112`	`let sum_from_stat = accumulator`