Skip to content

Make array metadata mandatory#5014

Closed
gatesn wants to merge 2 commits intodevelopfrom
ngates/mandatory-metadata
Closed

Make array metadata mandatory#5014
gatesn wants to merge 2 commits intodevelopfrom
ngates/mandatory-metadata

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Oct 20, 2025

As part of #4492 - makes array metadata mandatory.

Next step is to rename EncodeVTable to EncodingVTable, and move SerdeVTable::build to EncodingVTable (in effect, making serde mandatory)

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn mentioned this pull request Oct 20, 2025
6 tasks
@gatesn gatesn added the changelog/chore A trivial change label Oct 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #5014 will not alter performance

Comparing ngates/mandatory-metadata (5c22581) with develop (5348219)

Summary

✅ 1309 untouched

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 77.29469% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.29%. Comparing base (5348219) to head (5c22581).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/alp/src/alp_rd/serde.rs 0.00% 15 Missing ⚠️
vortex-array/src/arrays/list/vtable/visitor.rs 0.00% 6 Missing ⚠️
encodings/bytebool/src/serde.rs 0.00% 4 Missing ⚠️
encodings/zigzag/src/serde.rs 0.00% 4 Missing ⚠️
vortex-array/src/arrays/null/mod.rs 0.00% 4 Missing ⚠️
vortex-array/src/arrays/chunked/vtable/visitor.rs 0.00% 3 Missing ⚠️
vortex-array/src/arrow/array.rs 0.00% 3 Missing ⚠️
vortex-array/src/patches.rs 60.00% 2 Missing ⚠️
encodings/pco/src/serde.rs 80.00% 1 Missing ⚠️
encodings/sparse/src/serde.rs 83.33% 1 Missing ⚠️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn enabled auto-merge (squash) October 20, 2025 22:02
@gatesn gatesn disabled auto-merge October 20, 2025 22:05
@gatesn gatesn closed this Oct 21, 2025
@robert3005 robert3005 deleted the ngates/mandatory-metadata branch October 21, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments