Skip to content

Chore: rename PVector to PVec#5078

Closed
connortsui20 wants to merge 1 commit intodevelopfrom
ct/rename-pvector
Closed

Chore: rename PVector to PVec#5078
connortsui20 wants to merge 1 commit intodevelopfrom
ct/rename-pvector

Conversation

@connortsui20
Copy link
Contributor

Since it will be quite similar to Vec from the standard library.

@connortsui20 connortsui20 requested a review from gatesn October 24, 2025 21:21
@connortsui20 connortsui20 added the changelog/chore A trivial change label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 56.86275% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.42%. Comparing base (2f09c15) to head (8afab09).

Files with missing lines Patch % Lines
vortex-vector/src/primitive/vector_mut.rs 57.69% 11 Missing ⚠️
vortex-vector/src/primitive/generic.rs 0.00% 7 Missing ⚠️
vortex-vector/src/primitive/generic_mut.rs 57.14% 3 Missing ⚠️
vortex-vector/src/primitive/vector.rs 75.00% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Since it will be quite similar to `Vec` from the standard library.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@gatesn
Copy link
Contributor

gatesn commented Oct 24, 2025

Everything in this crate is called Vector, I think we should be consistent with that rather than stdlib.

@gatesn gatesn closed this Oct 24, 2025
@connortsui20 connortsui20 deleted the ct/rename-pvector branch October 27, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants