-
Notifications
You must be signed in to change notification settings - Fork 112
Fix: IPC AsyncMessageReader does not handle partial reads
#5758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
actually I just realized this does not handle EOF in the middle of a partial read as an error |
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gatesn can you take a look again I made some changes |
Signed-off-by: blaginin <[email protected]>
Signed-off-by: Connor Tsui <[email protected]>
8f76f01 to
d534e33
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Deploying vortex-bench with
|
| Latest commit: |
dc65ef8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7259c965.vortex-93b.pages.dev |
| Branch Preview URL: | https://db-failing-stream.vortex-93b.pages.dev |
Fixes: #5633
I doubt that the extra enums I added for readability will hurt performance in any meaningful way.