Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 16, 2025

Fixes: #5633

I doubt that the extra enums I added for readability will hurt performance in any meaningful way.

@connortsui20
Copy link
Contributor Author

actually I just realized this does not handle EOF in the middle of a partial read as an error

@connortsui20 connortsui20 marked this pull request as draft December 16, 2025 18:30
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.95%. Comparing base (da5d463) to head (dc65ef8).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-ipc/src/messages/reader_async.rs 88.09% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gatesn
gatesn previously approved these changes Dec 16, 2025
@connortsui20
Copy link
Contributor Author

@gatesn can you take a look again I made some changes

@connortsui20 connortsui20 marked this pull request as ready for review December 16, 2025 18:46
@codspeed-hq

This comment was marked as off-topic.

@connortsui20 connortsui20 enabled auto-merge (squash) December 17, 2025 18:08
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2026

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc65ef8
Status: ✅  Deploy successful!
Preview URL: https://7259c965.vortex-93b.pages.dev
Branch Preview URL: https://db-failing-stream.vortex-93b.pages.dev

View logs

@connortsui20 connortsui20 merged commit b3231e4 into develop Jan 5, 2026
49 checks passed
@connortsui20 connortsui20 deleted the db/failing-stream branch January 5, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants