Skip to content

Conversation

@Pratham1812
Copy link
Contributor

This change removes all the instances of vortex_unwrap and replaces them with vortex_expect essentially compelling the user to provide a justification of failure.

Signed-off-by: Pratham Agarwal <[email protected]>
@Pratham1812
Copy link
Contributor Author

Hello Can anybody please review this?

Copy link
Contributor

@gatesn gatesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just FYI, most of the team are off for the holidays now until January so reviews may be slow / delayed

@gatesn gatesn enabled auto-merge (squash) December 23, 2025 17:59
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 96.30996% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.94%. Comparing base (1e0f608) to head (7fd5e34).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
encodings/fsst/src/test_utils.rs 0.00% 2 Missing ⚠️
vortex-array/src/expr/mod.rs 0.00% 2 Missing ⚠️
vortex-duckdb/src/exporter/list.rs 50.00% 2 Missing ⚠️
vortex-duckdb/src/exporter/list_view.rs 66.66% 2 Missing ⚠️
vortex-array/src/arrays/dict_test.rs 0.00% 1 Missing ⚠️
vortex-btrblocks/src/integer/stats.rs 87.50% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pratham1812 Pratham1812 changed the title Removes vortex_unwrap completely in favor of vortex_expect Fix: Removes vortex_unwrap completely in favor of vortex_expect Dec 23, 2025
@gatesn gatesn added the chore Release label indicating a trivial change label Dec 23, 2025
@gatesn gatesn merged commit c7b0ef9 into vortex-data:develop Dec 23, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants