refactor: unify pre-commit configs and update CI workflow (#15)

* chore: update .gitignore to exclude .vscode/ and log/

* refactor: merge .pre-commit-config-local.yaml and .pre-commit-config.yaml and update CI workflow to use that new file, also removed pre-commit.ci badge from README

* refactor(workflows): update job names and when different workflows run

Author: kluge7

.github/workflows/code-coverage.yml

@@ -4,10 +4,9 @@ on:
     branches:
       - main
   pull_request:
-    branches:
-      - main
+    types: [ opened, synchronize, reopened, ready_for_review ]
 jobs:
-  call_reusable_workflow:
+  code-coverage:
     uses: vortexntnu/vortex-ci/.github/workflows/reusable-code-coverage.yml@main
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/industrial-ci.yml

@@ -2,11 +2,15 @@ name: Industrial CI
 
 on:
   push:
+    branches:
+      - main
+  pull_request:
+    types: [ opened, synchronize, reopened, ready_for_review ]
   workflow_dispatch:
   schedule:
     - cron: '0 1 * * *' # Runs daily to check for dependency issues or flaking tests
 jobs:
-  call_reusable_workflow:
+  industrial-ci:
     uses: vortexntnu/vortex-ci/.github/workflows/reusable-industrial-ci.yml@main
     with:
         ros_repo: '["testing", "main"]'

.github/workflows/pre-commit.yml

@@ -1,11 +1,14 @@
 name: pre-commit
-
 on:
+  push:
+    branches:
+      - main
   pull_request:
+    types: [ opened, synchronize, reopened, ready_for_review ]
   workflow_dispatch:
 jobs:
-  call_reusable_workflow:
+  pre-commit:
     uses: vortexntnu/vortex-ci/.github/workflows/reusable-pre-commit.yml@main
     with:
         ros_distro: 'humble'
-        config_path: '.pre-commit-config-local.yaml'
+        config_path: '.pre-commit-config.yaml'

.github/workflows/semantic-release.yml

@@ -5,5 +5,5 @@ on:
     branches:
       - main
 jobs:
-  call_reusable_workflow:
+  semantic-release:
     uses: vortexntnu/vortex-ci/.github/workflows/reusable-semantic-release.yml@main

.gitignore

@@ -50,3 +50,6 @@ qtcreator-*
 
 # Catkin custom files
 CATKIN_IGNORE
+
+.vscode/
+log/

.pre-commit-config-local.yaml

@@ -78,6 +78,35 @@ repos:
     hooks:
       - id: clang-format
         args: [--style=file]
+  - repo: local
+    hooks:
+      - id: ament_cppcheck
+        name: ament_cppcheck
+        description: Static code analysis of C/C++ files.
+        entry: env AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS=1 ament_cppcheck
+        language: system
+        files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
+  - repo: local
+    hooks:
+      - id: ament_cpplint
+        name: ament_cpplint
+        description: Static code analysis of C/C++ files.
+        entry: ament_cpplint
+        language: system
+        files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
+        args: [
+          "--linelength=100",
+          "--filter=-whitespace/newline,-legal/copyright,-build/include_order"
+        ]
+  # CMake hooks
+  - repo: local
+    hooks:
+      - id: ament_lint_cmake
+        name: ament_lint_cmake
+        description: Check format of CMakeLists.txt files.
+        entry: ament_lint_cmake
+        language: system
+        files: CMakeLists\.txt$
   # Spellcheck in comments and docs
   - repo: https://github.com/codespell-project/codespell
     rev: v2.4.1

.pre-commit-config.yaml

@@ -1,6 +1,5 @@
 # Image Filtering Node
 [![Industrial CI](https://github.com/vortexntnu/vortex-image-filtering/actions/workflows/industrial-ci.yml/badge.svg)](https://github.com/vortexntnu/vortex-image-filtering/actions/workflows/industrial-ci.yml)
-[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/vortexntnu/vortex-image-filtering/main.svg)](https://results.pre-commit.ci/latest/github/vortexntnu/vortex-image-filtering/main)
 [![codecov](https://codecov.io/github/vortexntnu/vortex-image-filtering/graph/badge.svg?token=6XHprkpUsR)](https://codecov.io/github/vortexntnu/vortex-image-filtering)
 
 The `image_filtering_node` is a ROS 2 node developed in the `vortex::image_filters` namespace. It is designed to subscribe to image topics, apply various image filters using OpenCV, and publish the filtered images back to ROS.