Add tests for C++ code and refactor python tests #3
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
===========================================
+ Coverage 86.27% 96.73% +10.45%
===========================================
Files 4 5 +1
Lines 153 306 +153
Branches 2 40 +38
===========================================
+ Hits 132 296 +164
+ Misses 20 0 -20
- Partials 1 10 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
should add documentation for each test explaining what you are testing
There was a problem hiding this comment.
what part is not "self documenting", or you feel needs documentation? I feel like docs here would just repeat what the code says 🤷
There was a problem hiding this comment.
You have a point but comments make the purpose of the test clearer, which is important if someone new were to look at the code later
There was a problem hiding this comment.
I can cook some comments then
| } | ||
|
|
||
| TEST(quat_to_euler, test_quat_to_euler_5) { | ||
| Eigen::Quaterniond q5(0.770, 0.4207, -0.4207, -0.229); | ||
| Eigen::Vector3d expected5(1.0, -1.0, 0.0); | ||
| Eigen::Vector3d result5 = quat_to_euler(q5); | ||
| for (int i = 0; i < 3; ++i) { | ||
| EXPECT_NEAR(expected5[i], result5[i], 0.01); | ||
| } | ||
| } | ||
|
|
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Should be 100% coverage now 🙏