Skip to content

Commit 747c605

Browse files
authored
Merge pull request #15 from 0xPranjl/main, fixes #10
moved credentials from firebase.js to .env
2 parents b980546 + dc6001d commit 747c605

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

.env.sample

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,9 @@
1-
REACT_APP_API_KEY=gh_xxxxxxxx...
1+
REACT_APP_API_KEY=gh_xxxxxxxx...,
2+
REACT_APP_FIRBASE_API_KEY='AIzaSyDs-rxvOLmskYhudQWPOxl-whELlKKUYhs',
3+
REACT_APP_AUTHDOMAIN="issue-finder.firebaseapp.com",
4+
REACT_APP_PROJECTID='issue-finder',
5+
REACT_APP_STORAGEBUCKET='issue-finder.appspot.com',
6+
REACT_APP_MSG_SENDERID='918268898722',
7+
REACT_APP_APPID='1:918268898722:web:653b04454a9eee41d896fb',
8+
REACT_APP_MEASUREMENTID='G-C28740E7D5'
9+

src/utility/firebase.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ import { getAnalytics } from 'firebase/analytics';
88
// Your web app's Firebase configuration
99
// For Firebase JS SDK v7.20.0 and later, measurementId is optional
1010
const firebaseConfig = {
11-
apiKey: 'AIzaSyDs-rxvOLmskYhudQWPOxl-whELlKKUYhs',
12-
authDomain: 'issue-finder.firebaseapp.com',
13-
projectId: 'issue-finder',
14-
storageBucket: 'issue-finder.appspot.com',
15-
messagingSenderId: '918268898722',
16-
appId: '1:918268898722:web:653b04454a9eee41d896fb',
17-
measurementId: 'G-C28740E7D5'
11+
apiKey:process.env.REACT_APP_FIRBASE_API_KEY,
12+
authDomain: process.env.REACT_APP_AUTHDOMAIN,
13+
projectId: process.env.REACT_APP_PROJECTID,
14+
storageBucket:process.env.REACT_APP_STORAGEBUCKET,
15+
messagingSenderId:process.env.REACT_APP_MSG_SENDERID,
16+
appId: process.env.REACT_APP_APPID,
17+
measurementId: process.env.REACT_APP_MEASUREMENTID
1818
};
1919

2020
// Initialize Firebase

0 commit comments

Comments
 (0)