fix(utils,exp): logger compat issue and exp check (Megvii-BaseDetection#1618)

fix(utils,exp): logger compat issue and exp check (Megvii-BaseDetection#1618)

Author: FateScript

tools/train.py

@@ -11,7 +11,7 @@
 import torch.backends.cudnn as cudnn
 
 from yolox.core import launch
-from yolox.exp import Exp, get_exp
+from yolox.exp import Exp, check_exp_value, get_exp
 from yolox.utils import configure_module, configure_nccl, configure_omp, get_num_devices
 
 
@@ -123,6 +123,7 @@ def main(exp: Exp, args):
     args = make_parser().parse_args()
     exp = get_exp(args.exp_file, args.name)
     exp.merge(args.opts)
+    check_exp_value(exp)
 
     if not args.experiment_name:
         args.experiment_name = exp.exp_name

yolox/exp/__init__.py

@@ -1,7 +1,6 @@
 #!/usr/bin/env python3
-# -*- coding:utf-8 -*-
 # Copyright (c) Megvii Inc. All rights reserved.
 
 from .base_exp import BaseExp
 from .build import get_exp
-from .yolox_base import Exp
+from .yolox_base import Exp, check_exp_value

yolox/exp/base_exp.py

@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# -*- coding:utf-8 -*-
 # Copyright (c) Megvii Inc. All rights reserved.
 
 import ast
@@ -66,15 +65,15 @@ def __repr__(self):
         return tabulate(exp_table, headers=table_header, tablefmt="fancy_grid")
 
     def merge(self, cfg_list):
-        assert len(cfg_list) % 2 == 0
+        assert len(cfg_list) % 2 == 0, f"length must be even, check value here: {cfg_list}"
         for k, v in zip(cfg_list[0::2], cfg_list[1::2]):
             # only update value with same key
             if hasattr(self, k):
                 src_value = getattr(self, k)
                 src_type = type(src_value)
 
                 # pre-process input if source type is list or tuple
-                if isinstance(src_value, List) or isinstance(src_value, Tuple):
+                if isinstance(src_value, (List, Tuple)):
                     v = v.strip("[]()")
                     v = [t.strip() for t in v.split(",")]
 

yolox/exp/yolox_base.py

@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# -*- coding:utf-8 -*-
 # Copyright (c) Megvii Inc. All rights reserved.
 
 import os
@@ -11,6 +10,8 @@
 
 from .base_exp import BaseExp
 
+__all__ = ["Exp", "check_exp_value"]
+
 
 class Exp(BaseExp):
     def __init__(self):
@@ -350,3 +351,8 @@ def get_trainer(self, args):
 
     def eval(self, model, evaluator, is_distributed, half=False, return_outputs=False):
         return evaluator.evaluate(model, is_distributed, half, return_outputs=return_outputs)
+
+
+def check_exp_value(exp: Exp):
+    h, w = exp.input_size
+    assert h % 32 == 0 and w % 32 == 0, "input size must be multiples of 32"

yolox/utils/logger.py

@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# -*- coding:utf-8 -*-
 # Copyright (c) Megvii Inc. All rights reserved.
 
 import inspect
@@ -58,15 +57,20 @@ def write(self, buf):
             sys.__stdout__.write(buf)
 
     def flush(self):
-        pass
+        # flush is related with CPR(cursor position report) in terminal
+        return sys.__stdout__.flush()
 
     def isatty(self):
         # when using colab, jax is installed by default and issue like
         # https://github.com/Megvii-BaseDetection/YOLOX/issues/1437 might be raised
         # due to missing attribute like`isatty`.
         # For more details, checked the following link:
         # https://github.com/google/jax/blob/10720258ea7fb5bde997dfa2f3f71135ab7a6733/jax/_src/pretty_printer.py#L54  # noqa
-        return True
+        return sys.__stdout__.isatty()
+
+    def fileno(self):
+        # To solve the issue when using debug tools like pdb
+        return sys.__stdout__.fileno()
 
 
 def redirect_sys_output(log_level="INFO"):