Skip to content
This repository was archived by the owner on Sep 9, 2024. It is now read-only.

Commit 7c13ce5

Browse files
committed
More plugin loading fixes
- For Windows add avformat in the build cs file -> It looks like the file to be loaded from cpp module file must be in cs also - For macOS include the dvdnr lib in cpp module file -> It was in the C# build file as a runtime dep
1 parent 6aaac69 commit 7c13ce5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

DolbyIO/Source/DolbyIO.Build.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ public DolbyIO(ReadOnlyTargetRules Target) : base(Target)
3838

3939
string[] Dlls = new string[] { "avutil-57.dll",
4040
"avcodec-59.dll",
41+
"avformat-59.dll",
4142
"dvclient.dll",
4243
"dolbyio_comms_media.dll",
4344
"dolbyio_comms_sdk.dll",
@@ -69,12 +70,12 @@ public DolbyIO(ReadOnlyTargetRules Target) : base(Target)
6970
{
7071
RuntimeDependencies.Add(Lib);
7172
}
72-
RuntimeDependencies.Add(Path.Combine(LibDir, "libdlb_vidseg_c_api.dylib"));
7373
RuntimeDependencies.Add(Path.Combine(LibDir, "libdvclient.dylib"));
74-
RuntimeDependencies.Add(Path.Combine(LibDir, "libdvdnr.dylib"));
7574
RuntimeDependencies.Add(Path.Combine(LibDir, "libopencv_core.4.5.dylib"));
7675
RuntimeDependencies.Add(Path.Combine(LibDir, "libopencv_imgcodecs.4.5.dylib"));
7776
RuntimeDependencies.Add(Path.Combine(LibDir, "libopencv_imgproc.4.5.dylib"));
77+
RuntimeDependencies.Add(Path.Combine(LibDir, "libdvdnr.dylib"));
78+
RuntimeDependencies.Add(Path.Combine(LibDir, "libdlb_vidseg_c_api.dylib"));
7879
RuntimeDependencies.Add(Path.Combine(LibDir, "model.dnr"));
7980
RuntimeDependencies.Add(Path.Combine(LibDir, "video_processor.model"));
8081
}

DolbyIO/Source/Private/DolbyIOModule.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class FDolbyIOModule final : public IModuleInterface
2424
[](std::size_t Count, std::size_t Al) { return ::operator new(Count, static_cast<std::align_val_t>(Al)); },
2525
::operator delete,
2626
[](void* Ptr, std::size_t Al) { ::operator delete(Ptr, static_cast<std::align_val_t>(Al)); }};
27+
// Add this here as I am not sure how Windows paths are interpreted (do I need the backslash)
2728
BaseDir = FPaths::Combine(BaseDir, TEXT("bin"));
2829
LoadDll(BaseDir, "avutil-57.dll");
2930
LoadDll(BaseDir, "avcodec-59.dll");
@@ -35,6 +36,7 @@ class FDolbyIOModule final : public IModuleInterface
3536
LoadDll(BaseDir, "opencv_core451.dll");
3637
LoadDll(BaseDir, "opencv_imgproc451.dll");
3738
LoadDll(BaseDir, "opencv_imgcodecs451.dll");
39+
LoadDll(BaseDir, "dvdnr.dll");
3840
LoadDll(BaseDir, "dlb_vidseg_c_api.dll");
3941
LoadDll(BaseDir, "video_processor.dll");
4042
dolbyio::comms::plugin::video_processor::set_app_allocator(Allocator);
@@ -46,6 +48,7 @@ class FDolbyIOModule final : public IModuleInterface
4648
LoadDll(BaseDir, "lib/libopencv_imgproc.4.5.dylib");
4749
LoadDll(BaseDir, "lib/libopencv_imgcodecs.4.5.dylib");
4850
LoadDll(BaseDir, "lib/libdlb_vidseg_c_api.dylib");
51+
LoadDll(BaseDir, "lib/libdvdnr.dylib");
4952
LoadDll(BaseDir, "lib/libvideo_processor.dylib");
5053
#elif PLATFORM_LINUX
5154
BaseDir += "-ubuntu-20.04-clang10-libc++10";

0 commit comments

Comments
 (0)