Skip to content

Commit a8019f6

Browse files
authored
Merge pull request #546 from bastelfreak/ci2
CI: Mark release gem group as optional & please yaml linter for github workflows & configure minimal github token permissions
2 parents 033e114 + 368b2e6 commit a8019f6

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

.github/workflows/test.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
---
12
name: Test
23

34
on:
@@ -6,8 +7,8 @@ on:
67
branches:
78
- master
89

9-
env:
10-
BUNDLE_WITHOUT: release
10+
permissions:
11+
contents: read
1112

1213
jobs:
1314
test:
@@ -39,10 +40,15 @@ jobs:
3940
run: bundle exec rake ${{ matrix.rake_task }} RUBYOPT="${{ matrix.rubyopt }}"
4041
- name: Build gem
4142
run: gem build --strict --verbose *.gemspec
43+
4244
tests:
45+
if: always()
4346
needs:
4447
- test
45-
runs-on: ubuntu-latest
48+
runs-on: ubuntu-24.04
4649
name: Test suite
4750
steps:
48-
- run: echo Test suite completed
51+
- name: Decide whether the needed jobs succeeded or failed
52+
uses: re-actors/alls-green@release/v1
53+
with:
54+
jobs: ${{ toJSON(needs) }}

Gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ source 'https://rubygems.org'
22

33
gemspec
44

5-
group :release do
6-
gem 'faraday-retry', require: false
7-
gem 'github_changelog_generator', require: false
5+
group :release, optional: true do
6+
gem 'faraday-retry', '~> 2.1', require: false
7+
gem 'github_changelog_generator', '~> 1.16.4', require: false
88
end

0 commit comments

Comments
 (0)