Sysctls re-applied on every run

[sboyd-m]

This appears to be the same symptoms as in #63. I have tried versions 3.2.0 and 4.0.0 of this module but the bug is still present in the current version.

What's curious is this isn't affecting all sysctls, only some, but always the same ones. Currently we are managining these 4:

  net.ipv4.udp_rmem_min
  net.ipv4.udp_wmem_min
  net.core.rmem_max
  net.core.rmem_default

Here is the output of a debug run:

root@hostname:~# puppet agent -td 2>&1 | grep sysctl
Debug: Prefetching augeas resources for sysctl
Debug: Executing: '/usr/sbin/sysctl -e net.ipv4.udp_rmem_min net.ipv4.udp_wmem_min net.core.rmem_max net.core.rmem_default'
Debug: Executing: '/usr/sbin/sysctl -n net.ipv4.udp_rmem_min'
Debug: Executing: '/usr/sbin/sysctl -n net.ipv4.udp_wmem_min'
Debug: Executing: '/usr/sbin/sysctl -n net.core.rmem_max'
Debug: Executing: '/usr/sbin/sysctl -n net.core.rmem_max'
Debug: Executing: '/usr/sbin/sysctl -w net.core.rmem_max=26214400'
Debug: Executing: '/usr/sbin/sysctl -n net.core.rmem_default'
Debug: Executing: '/usr/sbin/sysctl -n net.core.rmem_default'
Debug: Executing: '/usr/sbin/sysctl -w net.core.rmem_default=26214400'

The default information is

Notice: /Stage[main]/Profiles::Sysctl/Sysctl[net.core.rmem_max]/value: changed configuration value from '' to '26214400'
Notice: /Stage[main]/Profiles::Sysctl/Sysctl[net.core.rmem_default]/value: changed configuration value from '' to '26214400

This is on Ubuntu 22.04

[sboyd-m]

Oh heavens, I figured it out. If the sysctl file has those sysctls set already, the values simply get added twice, rather than managed. This is a pretty odd bug, as I would expect the module to manage all matching entries in sysctl.conf.