type runscript can be specified as array with hashes

Author: project0

lib/puppet/parser/functions/bareos_settings.rb

@@ -16,7 +16,7 @@ module Puppet::Parser::Functions
         raise 'Name of directive config key is invalid' unless directive =~ %r{^[a-zA-z ]+$}
 
         # check array if allowed
-        values = if (type == 'acl' || type =~ %r{[_-]list$}) && value_setting.is_a?(Array)
+        values = if (%w[acl runscript].include?(type) || type =~ %r{[_-]list$}) && value_setting.is_a?(Array)
                    value_setting
                  else
                    [value_setting]

spec/functions/bareos_settings_spec.rb

@@ -133,7 +133,7 @@
       end
     end
   end
-  # add include_exclude_time / hash
+
   context 'type is an hashed value' do
     %w[include_exclude_item runscript hash].each do |type|
       it 'runs with compatible values' do
@@ -364,4 +364,34 @@
       end
     end
   end
+
+  context 'value can be an array' do
+    it 'any type with _list suffix' do
+      val = %w[first second]
+      result = "#{indent_default}Test = first
+#{indent_default}Test = second"
+      is_expected.to run.with_params([val, 'Test', 'string_noquote_list', true]).and_return(result)
+    end
+
+    it 'type is acl' do
+      val = %w[first second]
+      result = "#{indent_default}Test = first
+#{indent_default}Test = second"
+      is_expected.to run.with_params([val, 'Test', 'acl', true]).and_return(result)
+    end
+
+    it 'type is runcsript' do
+      val = [
+        { 'Test A' => 'value' },
+        { 'Test B' => 'value' }
+      ]
+      result = "#{indent_default}Test {
+#{indent_default}#{indent_default}Test A = value
+#{indent_default}}
+#{indent_default}Test {
+#{indent_default}#{indent_default}Test B = value
+#{indent_default}}"
+      is_expected.to run.with_params([val, 'Test', 'runscript', true]).and_return(result)
+    end
+  end
 end