manifests/plugin: reorder plugin notify

In some rare cases Puppet starts to think that we are redefining the
elasticsearch_plugin entity when it is used before the actual resource
declaration and then applying the catalog fails:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER:
Server Error: Evaluation Error: Error while evaluating a Resource Statement,
Evaluation Error: Error while evaluating a Resource Override, Could not
autoload puppet/type/elasticsearch_plugin: Attempt to redefine entity
'http://puppet.com/2016.1/runtime/type/elasticsearch_plugin'. Set at unknown
location at
/etc/puppetlabs/code/environments/main/modules/elasticsearch/manifests/plugin.pp:94:5
at
/etc/puppetlabs/code/environments/main/core/profiles/manifests/foo/elasticsearch.pp:104
on node
foo.bar.540455029edf40888d96132b81ff8db7f1d553bc

This output is from the older plugin version but it happens with the newer one
as well since the same code block exists in both versions.Reordering and putting
the notify block after declaring the resource fixes this problem.

Author: GiedriusS

manifests/plugin.pp

@@ -90,12 +90,6 @@
     default: { }
   }
 
-  if ! empty($instances) and $elasticsearch::restart_plugin_change {
-    Elasticsearch_plugin[$name] {
-      notify +> Elasticsearch::Instance[$instances],
-    }
-  }
-
   # set proxy by override or parse and use proxy_url from
   # elasticsearch::proxy_url or use no proxy at all
 
@@ -149,4 +143,10 @@
     recurse => true,
     before  => $_file_before,
   }
+
+  if ! empty($instances) and $elasticsearch::restart_plugin_change {
+    Elasticsearch_plugin[$name] {
+      notify +> Elasticsearch::Instance[$instances],
+    }
+  }
 }