Move log fetching into per-example failure :after hook

Author: tylerjl

spec/helpers/acceptance/tests/manifest_shared_examples.rb

@@ -41,7 +41,7 @@ class { 'elasticsearch' :
     end
 
     if idempotency_check
-      it 'is idempotent' do
+      it 'is idempotent', :logs_on_failure do
         apply_manifest applied_manifest, :catch_changes => true
       end
     end

spec/spec_helper_acceptance.rb

@@ -125,6 +125,17 @@ class { 'elasticsearch':
   c.before :context, :first_purge do
     shell 'rm -rf {/usr/share,/etc,/var/lib}/elasticsearch*'
   end
+
+  # Provide a hook filter to spit out some ES logs if the example fails.
+  c.after(:example, :logs_on_failure) do |example|
+    if example.exception
+      hosts.each do |host|
+        on host, "find / -name '#{v[:cluster_name]}.log' | xargs cat || true" do |result|
+          puts result.formatted_output
+        end
+      end
+    end
+  end
 end
 
 files_dir = ENV['files_dir'] || './spec/fixtures/artifacts'
@@ -259,16 +270,6 @@ class { "java" :
       MANIFEST
     end
   end
-
-  c.after :suite do |suite|
-    unless suite.reporter.failed_examples.empty?
-      hosts.each do |host|
-        on host, 'find /var/log/elasticsearch | xargs cat || true' do |result|
-          puts result.formatted_output
-        end
-      end
-    end
-  end
 end
 
 # Java 8 is only easy to manage on recent distros