Deduplicate test

Author: smortex

spec/defines/007_elasticsearch_user_spec.rb

@@ -49,83 +49,42 @@ class { 'elasticsearch': }
       end
 
       describe 'collector ordering' do
-        describe 'when present' do
-          let(:pre_condition) do
-            <<-EOS
-              class { 'elasticsearch': }
-              elasticsearch::template { 'foo': content => {"foo" => "bar"} }
-              elasticsearch::role { 'test_role':
-                privileges => {
-                  'cluster' => 'monitor',
-                  'indices' => {
-                    '*' => 'all',
-                  },
+        let(:pre_condition) do
+          <<-EOS
+            class { 'elasticsearch': }
+            elasticsearch::template { 'foo': content => {"foo" => "bar"} }
+            elasticsearch::role { 'test_role':
+              privileges => {
+                'cluster' => 'monitor',
+                'indices' => {
+                  '*' => 'all',
                 },
-              }
-            EOS
-          end
-
-          let(:params) do
-            {
-              password: 'foobar',
-              roles: %w[monitor user]
+              },
             }
-          end
-
-          it { is_expected.to contain_elasticsearch__role('test_role') }
-          it { is_expected.to contain_elasticsearch_role('test_role') }
-          it { is_expected.to contain_elasticsearch_role_mapping('test_role') }
+          EOS
+        end
 
-          it {
-            expect(subject).to contain_elasticsearch__user('elastic').
-              that_comes_before([
-                                  'Elasticsearch::Template[foo]'
-                                ]).that_requires([
-                                                   'Elasticsearch::Role[test_role]'
-                                                 ])
+        let(:params) do
+          {
+            password: 'foobar',
+            roles: %w[monitor user]
           }
-
-          include_examples 'class', :systemd
         end
 
-        describe 'when absent' do
-          let(:pre_condition) do
-            <<-EOS
-              class { 'elasticsearch': }
-              elasticsearch::template { 'foo': content => {"foo" => "bar"} }
-              elasticsearch::role { 'test_role':
-                privileges => {
-                  'cluster' => 'monitor',
-                  'indices' => {
-                    '*' => 'all',
-                  },
-                },
-              }
-            EOS
-          end
-
-          let(:params) do
-            {
-              password: 'foobar',
-              roles: %w[monitor user]
-            }
-          end
+        it { is_expected.to contain_elasticsearch__role('test_role') }
+        it { is_expected.to contain_elasticsearch_role('test_role') }
+        it { is_expected.to contain_elasticsearch_role_mapping('test_role') }
 
-          it { is_expected.to contain_elasticsearch__role('test_role') }
-          it { is_expected.to contain_elasticsearch_role('test_role') }
-          it { is_expected.to contain_elasticsearch_role_mapping('test_role') }
+        it {
+          expect(subject).to contain_elasticsearch__user('elastic').
+            that_comes_before([
+                                'Elasticsearch::Template[foo]'
+                              ]).that_requires([
+                                                 'Elasticsearch::Role[test_role]'
+                                               ])
+        }
 
-          it {
-            expect(subject).to contain_elasticsearch__user('elastic').
-              that_comes_before([
-                                  'Elasticsearch::Template[foo]'
-                                ]).that_requires([
-                                                   'Elasticsearch::Role[test_role]'
-                                                 ])
-          }
-
-          include_examples 'class', :systemd
-        end
+        include_examples 'class', :systemd
       end
     end
   end