Do not make a hiera() call in yaml data files

Author: tylerjl

CHANGELOG.md

@@ -11,6 +11,7 @@ Puppet 4.10.0 is the new minimum required version of Puppet.
 * Package management on apt-based systems no longer encounters dependency errors when `manage_repo => false`.
 * An error related to elasticsearch_roles and `yield` errors has been fixed
 * Correctly permit instances to be set to `absent` without errors.
+* Resolved an issue arising from the use of `hiera()` in Hiera yaml data files.
 
 #### Features
 

data/common.yaml

@@ -39,7 +39,7 @@ elasticsearch::package_provider: package
 elasticsearch::package_url: ~
 elasticsearch::pid_dir: /var/run/elasticsearch
 elasticsearch::pipelines: {}
-elasticsearch::plugindir: "%{hiera('elasticsearch::homedir')}/plugins"
+elasticsearch::plugindir: ~
 elasticsearch::plugins: {}
 elasticsearch::proxy_url: ~
 elasticsearch::purge_configdir: false

manifests/config.pp

@@ -36,7 +36,7 @@
         group  => $elasticsearch::elasticsearch_group,
         owner  => $elasticsearch::elasticsearch_user,
         mode   => '0750';
-      $elasticsearch::plugindir:
+      $elasticsearch::_plugindir:
         ensure => 'directory',
         group  => $elasticsearch::elasticsearch_group,
         owner  => $elasticsearch::elasticsearch_user,
@@ -160,7 +160,7 @@
 
   } elsif ( $elasticsearch::ensure == 'absent' ) {
 
-    file { $elasticsearch::plugindir:
+    file { $elasticsearch::_plugindir:
       ensure => 'absent',
       force  => true,
       backup => false,

manifests/init.pp

@@ -341,7 +341,7 @@
   Optional[String]                                $package_url,
   Optional[Stdlib::Absolutepath]                  $pid_dir,
   Hash                                            $pipelines,
-  Stdlib::Absolutepath                            $plugindir,
+  Optional[Stdlib::Absolutepath]                  $plugindir,
   Hash                                            $plugins,
   Optional[Stdlib::HTTPUrl]                       $proxy_url,
   Boolean                                         $purge_configdir,
@@ -407,6 +407,13 @@
     default => $package_name,
   }
 
+  # Set the plugin path variable for use later in the module.
+  if $plugindir == undef {
+    $_plugindir = "${homedir}/plugins"
+  } else {
+    $_plugindir = $plugindir
+  }
+
   #### Manage actions
 
   contain elasticsearch::package

manifests/package.pp

@@ -182,7 +182,7 @@
 
     exec { 'remove_plugin_dir':
       refreshonly => true,
-      command     => "rm -rf ${elasticsearch::plugindir}",
+      command     => "rm -rf ${elasticsearch::_plugindir}",
     }
 
 

manifests/plugin.pp

@@ -85,7 +85,7 @@
     }
     'absent': {
       $_file_ensure = $ensure
-      $_file_before = File[$elasticsearch::plugindir]
+      $_file_before = File[$elasticsearch::_plugindir]
     }
     default: { }
   }
@@ -134,10 +134,10 @@
     source                     => $file_source,
     url                        => $url,
     proxy                      => $_proxy,
-    plugin_dir                 => $::elasticsearch::plugindir,
+    plugin_dir                 => $::elasticsearch::_plugindir,
     plugin_path                => $module_dir,
   }
-  -> file { "${elasticsearch::plugindir}/${_module_dir}":
+  -> file { "${elasticsearch::_plugindir}/${_module_dir}":
     ensure  => $_file_ensure,
     mode    => 'o+Xr',
     recurse => true,