Skip to content

Commit b1ab9c2

Browse files
authored
Merge pull request #1115 from Kuermel/master
Increase of the role-name length to 40
2 parents 243abb5 + 61ddce4 commit b1ab9c2

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

lib/puppet/type/elasticsearch_role.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
newparam(:name, :namevar => true) do
77
desc 'Role name.'
88

9-
newvalues(/^[a-zA-Z_]{1}[-\w@.$]{0,29}$/)
9+
newvalues(/^[a-zA-Z_]{1}[-\w@.$]{0,39}$/)
1010
end
1111

1212
newproperty(:privileges) do

lib/puppet/type/elasticsearch_role_mapping.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
newparam(:name, :namevar => true) do
77
desc 'Role name.'
88

9-
newvalues(/^[a-zA-Z_]{1}[-\w@.$]{0,29}$/)
9+
newvalues(/^[a-zA-Z_]{1}[-\w@.$]{0,39}$/)
1010
end
1111

1212
newproperty(:mappings, :array_matching => :all) do

manifests/role.pp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
Array $mappings = [],
3333
Hash $privileges = {},
3434
) {
35-
validate_slength($name, 30, 1)
35+
validate_slength($name, 40, 1)
3636

3737
if empty($privileges) or $ensure == 'absent' {
3838
$_role_ensure = 'absent'

spec/defines/008_elasticsearch_role_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class { 'elasticsearch': }
3939

4040
context 'with an invalid role name' do
4141
context 'too long' do
42-
let(:title) { 'A' * 31 }
42+
let(:title) { 'A' * 41 }
4343
it { should raise_error(Puppet::Error, /expected length/i) }
4444
end
4545
end

spec/unit/type/elasticsearch_role_mapping_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
describe 'name' do
4545
it 'should reject long role names' do
4646
expect { described_class.new(
47-
:name => 'a' * 31
47+
:name => 'a' * 41
4848
) }.to raise_error(
4949
Puppet::ResourceError,
5050
/valid values/i

spec/unit/type/elasticsearch_role_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
describe 'name' do
4545
it 'should reject long role names' do
4646
expect { described_class.new(
47-
:name => 'a' * 31
47+
:name => 'a' * 41
4848
) }.to raise_error(
4949
Puppet::ResourceError,
5050
/valid values/i

0 commit comments

Comments
 (0)