Use a stricter data type on gluster::volumes

Author: ekohl

manifests/init.pp

@@ -48,7 +48,7 @@
   $server_package         = $gluster::params::server_package,
   $use_exported_resources = $gluster::params::export_resources,
   $version                = $gluster::params::version,
-  Optional[Hash] $volumes = undef,
+  Hash[String, Any] $volumes = {},
 ) inherits ::gluster::params {
 
   class { 'gluster::install':
@@ -76,8 +76,10 @@
       Gluster::Peer <<| pool == $pool |>>
     }
 
-    if $volumes {
-      create_resources( ::gluster::volume, $volumes )
+    $volumes.each |$volume, $options| {
+      gluster::volume { $volume:
+        * => $options,
+      }
     }
   }
 }

spec/classes/init_spec.rb

@@ -179,9 +179,7 @@
         end
 
         it 'fails' do
-          expect do
-            is_expected.to contain_gluster__volume('data1')
-          end.to raise_error(Puppet::Error, %r{})
+          is_expected.to compile.and_raise_error(%r{Expected value of type Hash, got Array})
         end
       end
     end