Fix legacy facts

Author: dhoppe

manifests/init.pp

@@ -68,7 +68,7 @@
 
     if $use_exported_resources {
       # first we export this server's instance
-      @@gluster::peer { $::fqdn:
+      @@gluster::peer { $facts['networking']['fqdn']:
         pool => $pool,
       }
 

manifests/params.pp

@@ -18,17 +18,17 @@
   # Set distro/release specific names, repo versions, repo gpg keys, package versions, etc
   # if the user didn't specify a version, just use "installed" for package version.
   # if they did specify a version, assume they provided a valid one
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat': {
       $repo                 = true
       $repo_gpg_key_source  = 'https://raw.githubusercontent.com/CentOS-Storage-SIG/centos-release-storage-common/master/RPM-GPG-KEY-CentOS-SIG-Storage'
 
-      $server_package = $::operatingsystemmajrelease ? {
+      $server_package = $facts['os']['release']['major'] ? {
         # RHEL 6 and 7 provide Gluster packages natively
         /(6|7)/ => 'glusterfs-server',
         default => false
       }
-      $client_package = $::operatingsystemmajrelease ? {
+      $client_package = $facts['os']['release']['major'] ? {
         /(6|7)/ => 'glusterfs-fuse',
         default => false,
       }

manifests/peer.pp

@@ -36,7 +36,7 @@
 #
 define gluster::peer (
   $pool = 'default',
-  $fqdn = $::fqdn,
+  $fqdn = $facts['networking']['fqdn'],
 ) {
 
   # we can't do much without the Gluster binary
@@ -45,7 +45,7 @@
   if getvar('::gluster_binary') {
     # we can't join to ourselves, so it only makes sense to operate
     # on other gluster servers in the same pool
-    if $fqdn != $::fqdn {
+    if $fqdn != $facts['networking']['fqdn'] {
 
       # and we don't want to attach a server that is already a member
       # of the current pool

manifests/repo.pp

@@ -19,7 +19,7 @@
   $release = $gluster::params::release,
   $version = $gluster::params::version,
 ) inherits gluster::params {
-  case $::osfamily {
+  case $facts['os']['family'] {
     'RedHat': {
       class { 'gluster::repo::yum':
         release => $release,
@@ -30,6 +30,6 @@
         version  => $version,
       }
     }
-    default: { fail("${::osfamily} not yet supported!") }
+    default: { fail("${facts['os']['family']} not yet supported!") }
   }
 }

manifests/repo/apt.pp

@@ -51,23 +51,23 @@
   } elsif $version =~ /^(\d)\.(\d+)\.(\d+).*$/ {
     $repo_ver =  "${1}.${2}/${1}.${2}.${3}"
   } else {
-    fail("${version} doesn't make sense for ${::operatingsystem}!")
+    fail("${version} doesn't make sense for ${facts['os']['name']}!")
   }
 
   # the Gluster repo only supports x86_64 (amd64) and arm64. The Ubuntu PPA also supports armhf and arm64.
-  case $::operatingsystem {
+  case $facts['os']['name'] {
     'Debian': {
-      case $::lsbdistcodename {
+      case $facts['os']['distro']['codename'] {
         'jessie', 'stretch':  {
-          $arch = $::architecture ? {
+          $arch = $facts['os']['architecture'] ? {
             'amd64'      => 'amd64',
             'arm64'      => 'arm64',
             default      => false,
           }
           if versioncmp($release, '3.12') < 0 {
-            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/apt/"
+            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${facts['os']['distro']['codename']}/apt/"
           } else {
-            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${::lsbdistcodename}/${arch}/apt/"
+            $repo_url  = "https://download.gluster.org/pub/gluster/glusterfs/${release}/LATEST/Debian/${facts['os']['distro']['codename']}/${arch}/apt/"
           }
         }
       }
@@ -77,14 +77,14 @@
     }
   }
   if ! $arch {
-    fail("Architecture ${::architecture} not yet supported for ${::operatingsystem}.")
+    fail("Architecture ${facts['os']['architecture']} not yet supported for ${facts['os']['name']}.")
   }
 
   $repo = {
     "glusterfs-${version}" => {
       ensure       => present,
       location     => $repo_url,
-      release      => $::lsbdistcodename,
+      release      => $facts['os']['distro']['codename'],
       repos        => 'main',
       key          => {
         id         => $repo_key_name,

manifests/repo/yum.pp

@@ -21,28 +21,28 @@
 ) inherits gluster::params {
 
   # CentOS Gluster repo only supports x86_64
-  if $::architecture != 'x86_64' {
-    fail("Architecture ${::architecture} not yet supported for ${::operatingsystem}.")
+  if $facts['os']['architecture'] != 'x86_64' {
+    fail("Architecture ${facts['os']['architecture']} not yet supported for ${facts['os']['name']}.")
   }
 
   if $priority {
     if ! defined( Package['yum-plugin-priorities'] ) {
       package { 'yum-plugin-priorities':
         ensure => installed,
-        before => Yumrepo["glusterfs-${::architecture}"],
+        before => Yumrepo["glusterfs-${facts['os']['architecture']}"],
       }
     }
   }
 
-  yumrepo { "glusterfs-${::architecture}":
+  yumrepo { "glusterfs-${facts['os']['architecture']}":
     enabled  => 1,
-    baseurl  => "http://mirror.centos.org/centos/${::operatingsystemmajrelease}/storage/${::architecture}/gluster-${release}/",
-    descr    => "CentOS-${::operatingsystemmajrelease} - Gluster ${release}",
+    baseurl  => "http://mirror.centos.org/centos/${facts['os']['release']['major']}/storage/${facts['os']['architecture']}/gluster-${release}/",
+    descr    => "CentOS-${facts['os']['release']['major']} - Gluster ${release}",
     gpgcheck => 1,
     gpgkey   => $repo_key_source,
     priority => $priority,
   }
 
-  Yumrepo["glusterfs-${::architecture}"] -> Package<| tag == 'gluster-packages' |>
+  Yumrepo["glusterfs-${facts['os']['architecture']}"] -> Package<| tag == 'gluster-packages' |>
 
 }