Fixed code style and added tests

Fixed rubocop offenses.
Added peer test for case hostname != fqdn.
Added test for volume creation exec when there is only one node.

Author: glorpen

lib/facter/gluster.rb

@@ -30,17 +30,14 @@
   if peer_count > 0
     peer_list = output.scan(%r{^Hostname: (.+)$}).flatten.join(',')
     other_names = output.scan(%r{^Other names:\n((.+\n)+)}).flatten.join.scan(%r{(.+)\n?}).sort.uniq.flatten.join(',')
-    if other_names
-      peer_list += ',' +  other_names
-    end
+    peer_list += ',' + other_names if other_names
   end
   # note the stderr redirection here
   # `gluster volume list` spits to stderr :(
   output = Facter::Util::Resolution.exec("#{binary} volume list 2>&1")
   if output != 'No volumes present in cluster'
     output.split.each do |vol|
       info = Facter::Util::Resolution.exec("#{binary} volume info #{vol}")
-      # rubocop:disable Metrics/BlockNesting
       vol_status = Regexp.last_match[1] if info =~ %r{^Status: (.+)$}
       bricks = info.scan(%r{^Brick[^:]+: (.+)$}).flatten
       volume_bricks[vol] = bricks

spec/defines/peer_spec.rb

@@ -3,6 +3,12 @@
 describe 'gluster::peer', type: :define do
   let(:title) { 'peer1.example.com' }
 
+  let(:params) do
+    {
+      fqdn: 'peer1.example.com'
+    }
+  end
+
   describe 'missing gluster_binary fact' do
     it { is_expected.to compile }
     it { is_expected.not_to contain_exec('gluster peer probe peer1.example.com') }
@@ -51,7 +57,8 @@
         {
           gluster_binary: '/usr/sbin/gluster',
           gluster_peer_count: 0,
-          gluster_peer_list: ''
+          gluster_peer_list: '',
+          fqdn: 'peer99.example.com'
         }
       end
 
@@ -63,7 +70,8 @@
         {
           gluster_binary: '/usr/sbin/gluster',
           gluster_peer_count: 1,
-          gluster_peer_list: 'peer2.example.com'
+          gluster_peer_list: 'peer2.example',
+          fqdn: 'peer99.example.com'
         }
       end
 
@@ -75,7 +83,8 @@
         {
           gluster_binary: '/usr/sbin/gluster',
           gluster_peer_count: 2,
-          gluster_peer_list: 'peer2.example.com,peer3.example.com'
+          gluster_peer_list: 'peer2.example,peer3.example',
+          fqdn: 'peer99.example.com'
         }
       end
 
@@ -84,7 +93,7 @@
     end
   end
 
-  describe 'self joining (fqdn matches resource title)' do
+  describe 'self joining' do
     let(:facts) do
       {
         gluster_binary: '/usr/sbin/gluster',
@@ -99,4 +108,19 @@
       is_expected.not_to contain_exec('gluster peer probe peer1.example.com')
     end
   end
+
+  describe 'use custom host name (not fqdn)' do
+    let(:title) { 'peer1.example' }
+    let(:facts) do
+      {
+        gluster_binary: '/usr/sbin/gluster',
+        gluster_peer_count: 0,
+        gluster_peer_list: '',
+        fqdn: 'peer99.example.com'
+      }
+    end
+
+    it { is_expected.to compile }
+    it { is_expected.to contain_exec('gluster peer probe peer1.example') }
+  end
 end

spec/defines/volume_spec.rb

@@ -94,4 +94,17 @@
       end
     end
   end
+
+  describe 'single node' do
+    let(:facts) do
+      {
+        gluster_binary: '/usr/sbin/gluster',
+        gluster_peer_count: 0,
+        gluster_peer_list: ''
+      }
+    end
+
+    it { is_expected.to compile.with_all_deps }
+    it { is_expected.to contain_exec("gluster create volume #{title}") }
+  end
 end